From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds
Date: Tue, 11 Dec 2018 14:03:18 +0000 [thread overview]
Message-ID: <20181211140318.kkciujb52xsqgf3c@bivouac.eciton.net> (raw)
In-Reply-To: <20181211132510.21359-1-ard.biesheuvel@linaro.org>
On Tue, Dec 11, 2018 at 02:25:10PM +0100, Ard Biesheuvel wrote:
> Ensure that we prevent the CPU from proceeding after having taken an
> unhandled exception on a RELEASE build, which does not contain the
> ASSERT() which ensures this on DEBUG and NOOPT builds.
Sounds like a good idea.
Some silly questions below:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> index 0b9da031b47d..9d96d5aabd96 100644
> --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> @@ -267,10 +267,15 @@ DefaultExceptionHandler (
> DEBUG ((EFI_D_ERROR, "\n"));
> ASSERT (FALSE);
>
> + if (!PcAdjust) {
Won't this always be 0 for a RELEASE build? (By convention if nothing else.)
And won't we already have ASSERTed in any other case?
> + CpuDeadLoop ();
> + }
> +
> // Clear the error registers that we have already displayed incase some one wants to keep going
> SystemContext.SystemContextArm->DFSR = 0;
> SystemContext.SystemContextArm->IFSR = 0;
>
> // If some one is stepping past the exception handler adjust the PC to point to the next instruction
> SystemContext.SystemContextArm->PC += PcAdjust;
> +
Hmm?
/
Leif
> }
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-11 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:25 [PATCH] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds Ard Biesheuvel
2018-12-11 14:03 ` Leif Lindholm [this message]
2018-12-11 14:06 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211140318.kkciujb52xsqgf3c@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox