From: Leif Lindholm <leif.lindholm@linaro.org>
To: Nariman Poushin <nariman.poushin@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2-platforms] [PATCH v2 1/2] Readme.md: Update instructions to fetch source
Date: Tue, 11 Dec 2018 18:32:47 +0000 [thread overview]
Message-ID: <20181211183247.4vfkle3yuxsxvkze@bivouac.eciton.net> (raw)
In-Reply-To: <1543243935-4242-1-git-send-email-nariman.poushin@linaro.org>
On Mon, Nov 26, 2018 at 02:52:14PM +0000, Nariman Poushin wrote:
> Openssl is fetched as a git submodule, so make sure git clone --recursive
> is specified in the instructions to fetch a full source tree.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 572a554e1d.
Did you send a v7(?) of 2/2, I haven't seen one?
(No panic if you haven't, just we had some emails going missing
earlier in this thread and I wanted to make sure that wasn't happening
again.)
/
Leif
> ---
>
> Changes since v1:
>
> - Added Contribution Agreement tag
>
> Readme.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Readme.md b/Readme.md
> index 6ad5953..bb53c6f 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain
> 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building
> platforms that need it)
> ```
> - $ git clone https://github.com/tianocore/edk2.git
> + $ git clone https://github.com/tianocore/edk2.git --recursive
> ...
> $ git clone https://github.com/tianocore/edk2-platforms.git
> ...
> --
> 2.7.4
>
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-12-11 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 13:10 [PATCH 1/2] Readme.md: Update instructions to fetch source Nariman Poushin
2018-11-26 13:10 ` [PATCH 2/2] Platform/ARM: Add Readme.md Nariman Poushin
2018-11-26 14:11 ` [PATCH 1/2] Readme.md: Update instructions to fetch source Gao, Liming
2018-11-26 14:15 ` Nariman Poushin
2018-11-26 14:52 ` [edk2-platforms] [PATCH v2 " Nariman Poushin
2018-11-26 14:52 ` [edk2-platforms] [PATCH v3 2/2] Platform/ARM: Add Readme.md Nariman Poushin
2018-12-11 18:32 ` Leif Lindholm [this message]
2018-12-12 15:19 ` [edk2-platforms] [PATCH v2 1/2] Readme.md: Update instructions to fetch source Nariman Poushin
2018-11-26 18:41 ` [PATCH " Leif Lindholm
2018-11-27 9:34 ` [edk2-platforms] [PATCH v2 " Nariman Poushin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211183247.4vfkle3yuxsxvkze@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox