From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>,
Bob Feng <bob.c.feng@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option
Date: Wed, 12 Dec 2018 11:33:08 +0100 [thread overview]
Message-ID: <20181212103308.8099-4-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20181212103308.8099-1-ard.biesheuvel@linaro.org>
Drop the -mno-movt command line option override, which is no longer
needed, and actually incompatible with versions of Clang before 3.6.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -----
ArmVirtPkg/ArmVirtXen.dsc | 5 -----
2 files changed, 10 deletions(-)
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index c4324a9e264b..df125cfef646 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -69,11 +69,6 @@ [LibraryClasses.common.UEFI_DRIVER]
UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
[BuildOptions.common.EDKII.SEC, BuildOptions.common.EDKII.BASE]
- # Avoid MOVT/MOVW instruction pairs in code that may end up in the PIE
- # executable we build for the relocatable PrePi. They are not runtime
- # relocatable in ELF.
- *_CLANG35_ARM_CC_FLAGS = -mno-movt
-
#
# CLANG38 with LTO support enabled uses the GNU GOLD linker, which insists
# on emitting GOT based symbol references when running in shared mode, unless
diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index e083666f54ea..a29d8a4ae717 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -58,11 +58,6 @@ [LibraryClasses.common.UEFI_DRIVER]
UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
[BuildOptions.common.EDKII.SEC, BuildOptions.common.EDKII.BASE]
- # Avoid MOVT/MOVW instruction pairs in code that may end up in the PIE
- # executable we build for the relocatable PrePi. They are not runtime
- # relocatable in ELF.
- *_CLANG35_ARM_CC_FLAGS = -mno-movt
-
#
# CLANG38 with LTO support enabled uses the GNU GOLD linker, which insists
# on emitting GOT based symbol references when running in shared mode, unless
--
2.19.2
next prev parent reply other threads:[~2018-12-12 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:33 [PATCH 0/3] fixes for CLANG35 on ARM Ard Biesheuvel
2018-12-12 10:33 ` [PATCH 1/3] MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations Ard Biesheuvel
2018-12-12 11:48 ` Laszlo Ersek
2018-12-12 10:33 ` [PATCH 2/3] BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change Ard Biesheuvel
2018-12-12 11:49 ` Laszlo Ersek
2018-12-12 11:51 ` Ard Biesheuvel
2018-12-12 12:04 ` Laszlo Ersek
2018-12-12 12:30 ` Ard Biesheuvel
2018-12-12 12:34 ` Leif Lindholm
2018-12-12 10:33 ` Ard Biesheuvel [this message]
2018-12-12 11:51 ` [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option Laszlo Ersek
2018-12-12 12:37 ` [PATCH 0/3] fixes for CLANG35 on ARM Leif Lindholm
2018-12-12 14:01 ` Gao, Liming
2018-12-12 14:02 ` Ard Biesheuvel
2018-12-12 14:19 ` Gao, Liming
2018-12-12 14:19 ` Ard Biesheuvel
2018-12-13 10:49 ` Ard Biesheuvel
2018-12-13 11:42 ` Gao, Liming
2018-12-13 11:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212103308.8099-4-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox