From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>,
Bob Feng <bob.c.feng@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM
Date: Wed, 12 Dec 2018 12:37:34 +0000 [thread overview]
Message-ID: <20181212123734.alyip2q3xbi7ezw4@bivouac.eciton.net> (raw)
In-Reply-To: <20181212103308.8099-1-ard.biesheuvel@linaro.org>
On Wed, Dec 12, 2018 at 11:33:05AM +0100, Ard Biesheuvel wrote:
> Building with Clang 3.5 for ARM may result in build breakage, due to the
> fact that it may emit non-adjacent movw/movt instructions pairs which
> cannot be relocated in PE/COFF. We pass -mno-movt in some places to
> work around a related issue in the relocatable PrePi in ArmVirtPkg, but
> we need to disable movw/movt entirely to really address this issue.
>
> So first, fix some breakage that results from building with -mlong-calls
> in the optimized BaseMemoryLib code (#1)
>
> Patch #2 switches to -mkernel, which disables movw/movt generation (and
> enabled -mlong-calls as a side effect)
>
> Patch #3 removes the now redundant, and incompatible command line
> overrides for the relocatable PrePi.
For 1,3/3:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
>
> Ard Biesheuvel (3):
> MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations
> BaseTools/tools_def ARM CLANG35: work around -mno-movt option name
> change
> ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option
>
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -----
> ArmVirtPkg/ArmVirtXen.dsc | 5 -----
> BaseTools/Conf/tools_def.template | 2 +-
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 +
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 +
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 +
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++
> 7 files changed, 9 insertions(+), 11 deletions(-)
>
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-12 12:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:33 [PATCH 0/3] fixes for CLANG35 on ARM Ard Biesheuvel
2018-12-12 10:33 ` [PATCH 1/3] MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations Ard Biesheuvel
2018-12-12 11:48 ` Laszlo Ersek
2018-12-12 10:33 ` [PATCH 2/3] BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change Ard Biesheuvel
2018-12-12 11:49 ` Laszlo Ersek
2018-12-12 11:51 ` Ard Biesheuvel
2018-12-12 12:04 ` Laszlo Ersek
2018-12-12 12:30 ` Ard Biesheuvel
2018-12-12 12:34 ` Leif Lindholm
2018-12-12 10:33 ` [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option Ard Biesheuvel
2018-12-12 11:51 ` Laszlo Ersek
2018-12-12 12:37 ` Leif Lindholm [this message]
2018-12-12 14:01 ` [PATCH 0/3] fixes for CLANG35 on ARM Gao, Liming
2018-12-12 14:02 ` Ard Biesheuvel
2018-12-12 14:19 ` Gao, Liming
2018-12-12 14:19 ` Ard Biesheuvel
2018-12-13 10:49 ` Ard Biesheuvel
2018-12-13 11:42 ` Gao, Liming
2018-12-13 11:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212123734.alyip2q3xbi7ezw4@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox