From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E9D8C2119C897 for ; Wed, 12 Dec 2018 04:37:38 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id r10so17518948wrs.10 for ; Wed, 12 Dec 2018 04:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I1bkNWt1T6u6rsrezrsNhIsDNGmOy+n/QkTikDCdqAY=; b=ZX0MweAKPEYP022Ia4indT0WdZjkOK22rqYehfBFItdis44dPhVFPzoSz70Z8aV+UA YjdiagFiHcEIcKq+H/uLzxOl/PeMXBoVSBrpgVkTw+ny/WylXL3ci3fJaQH1UOfcFPF1 XhPco4bmsx5Nyvbwiit2u7CEmkQJVnk2JWUIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I1bkNWt1T6u6rsrezrsNhIsDNGmOy+n/QkTikDCdqAY=; b=WojP/QOU/9rwSab9gKO565PA3gJMZApXGLoc7P25uykHpG5bCG5JP++HaVr0jt8SZx +0lZyG0u24LsyzxxRIPqPvHWAARMzjiYW+LpK9JRLqfDoXqyD5RBuo19G30mYo3ZecrZ LJSpaNOXFbE1hU7FP5sCalMhJnqGZZ7DVV8KJkfUCpoY1x0Yrh0g4UNIbWp4B9cYm9GC Yt1T7kFHy2TaB2bYKlEZNmJ/sN2FQXQfJHL3VFf56+F7Vd3eNw+mShF/LANMY0VaCm9x K7kYEM95qHk6qO9iINGeh5EkliE4RLcPlCNjORaLvFJTzUvJxw8HPyA0PfVZWqdlj3bH i/8g== X-Gm-Message-State: AA+aEWY8iTixMftE7dYPGr12eQB9ge/LshB/DtnJrC8jClZueVPQVLuV Tr0WRayfHao9GmFyBM2mZfZ41g== X-Google-Smtp-Source: AFSGD/UPOQNn3CmZe2jb8lHLjKV4A13SkUe2pKmpFDDVU56ATsTdm/YBcU5WnnFV37H4kn3jx0I5FQ== X-Received: by 2002:adf:bc87:: with SMTP id g7mr16440771wrh.250.1544618257358; Wed, 12 Dec 2018 04:37:37 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c77sm3771015wmh.12.2018.12.12.04.37.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 04:37:36 -0800 (PST) Date: Wed, 12 Dec 2018 12:37:34 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Michael D Kinney , Liming Gao , Bob Feng , Laszlo Ersek Message-ID: <20181212123734.alyip2q3xbi7ezw4@bivouac.eciton.net> References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181212103308.8099-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 12:37:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 12, 2018 at 11:33:05AM +0100, Ard Biesheuvel wrote: > Building with Clang 3.5 for ARM may result in build breakage, due to the > fact that it may emit non-adjacent movw/movt instructions pairs which > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > work around a related issue in the relocatable PrePi in ArmVirtPkg, but > we need to disable movw/movt entirely to really address this issue. > > So first, fix some breakage that results from building with -mlong-calls > in the optimized BaseMemoryLib code (#1) > > Patch #2 switches to -mkernel, which disables movw/movt generation (and > enabled -mlong-calls as a side effect) > > Patch #3 removes the now redundant, and incompatible command line > overrides for the relocatable PrePi. For 1,3/3: Reviewed-by: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Bob Feng > Cc: Leif Lindholm > Cc: Laszlo Ersek > > Ard Biesheuvel (3): > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > change > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > BaseTools/Conf/tools_def.template | 2 +- > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > 7 files changed, 9 insertions(+), 11 deletions(-) > > -- > 2.19.2 >