From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C92592119C89B for ; Wed, 12 Dec 2018 07:17:33 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id y139so6110560wmc.5 for ; Wed, 12 Dec 2018 07:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5hhtYCAh/93vfzuTAmK8jEPiX/e7fpHjo6W0w6s/qtU=; b=DGAbTg/D9Hy38ndRQPWZhkQMHHsmjm9qRUIU0v8m0+PVlz+1aoq2YcoWRC14E2KYRO Ord3vBjzuFBR6D+ijWTQJPOiKZOQxDJI2lhpYDjSzirNZmFVWc70zOkEuC4JGcLIv/LA M9nxYpbn8bbX13E65vUMzh8h3QPfeaMnZ2gIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5hhtYCAh/93vfzuTAmK8jEPiX/e7fpHjo6W0w6s/qtU=; b=hU9NqGpEsTLsYOwTgkZboK52HPYW98syWvbMBHHypBXO3SVBlsqu/lOdJ+7hWBz1Xv +TZmYKvzXrhVs3fBUY5oZKP5JopQrtShAvcXG4xhmYbeOgmw2/ZtCWSsraN+4HC26bFU D0uQaJLl2UcjwOGaTueYSAL91cvQhqB5kxajTbTNBhY6jkQ58d4sdU/86EklrmAX9ZZW C7NFJcpIM3SWH8rEFkdlJUWx2Sa1AZQst+LSPixfJPP/4rOZxMIsyxzwxLIDJYd1Osjv cu2Cx9wj9Uq0udr0sHXqGIzPXs785GXFW9P6pEt26OjuqVC29mTFWDgRPYFRfy0cNsC+ vf4Q== X-Gm-Message-State: AA+aEWZ2Rl+UN6ptZCnMng5UQPo1QKeuWYJb6X3/zZ3KkjLSAOLWtZJL 668v8iQfdMROCzqrpph9gZPOTw== X-Google-Smtp-Source: AFSGD/UK7NBt3JZXMx0opLCyuGTxt1wkqE9B019c3/ql4izBB57Hwu/9XEj9Tux1BN0x0hG9oKobEw== X-Received: by 2002:a1c:d7d3:: with SMTP id o202mr7120684wmg.135.1544627851981; Wed, 12 Dec 2018 07:17:31 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f66sm3750134wmd.28.2018.12.12.07.17.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 07:17:31 -0800 (PST) Date: Wed, 12 Dec 2018 15:17:29 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Andrew Fish Message-ID: <20181212151729.cdqz6fmw6a4ez5hh@bivouac.eciton.net> References: <20181212124842.15968-1-ard.biesheuvel@linaro.org> <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 15:17:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 12, 2018 at 04:10:37PM +0100, Ard Biesheuvel wrote: > On Wed, 12 Dec 2018 at 16:02, Leif Lindholm wrote: > > > > On Wed, Dec 12, 2018 at 01:48:42PM +0100, Ard Biesheuvel wrote: > > > The GdbDebugAgent library is unused and unmaintained, and now it > > > turns out it doesn't build with Clang, so let's just get rid of it. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > > Reviewed-by: Leif Lindholm > > But that's really only for the ARM-specific bits. > > > > Andrew, did anyone end up using this library for Ia32/X64? > > > > Considering the commit log from its introduction > > """ > commit 969eba7b0df70c9aa261eaf005085568b88de87c > Author: andrewfish > Date: Sat Apr 3 00:41:42 2010 +0000 > > Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have > low level interrupt code yet. I've been testing on ARM. > > git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334 > 6f19259b-4bc3-4df7-8a09-765794883524 > """ > > the lack of low level interrupt code in this patch, and the following > snippet from the .inf > > """ > [Sources.X64] > Ia32/Processor.c > > [Sources.Ia32] > X64/Processor.c > """ > > I think it is safe to say that this code was never used on anything but ARM. I believe the same, but since we have the author of both the code and that commit message easily accessible, I would like to verify before we nuke it. / Leif