public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, alan@softiron.co.uk
Subject: Re: [PATCH edk2-platforms 00/11] final set of Styx cleanups
Date: Wed, 12 Dec 2018 22:23:19 +0000	[thread overview]
Message-ID: <20181212222319.qhf27cxz5liuqprq@bivouac.eciton.net> (raw)
In-Reply-To: <20181211183514.20948-1-ard.biesheuvel@linaro.org>

On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:
> I promise :-)

Yeah, right :)

> This gets rid of the last build config options passed via the command
> line into the preprocessor, and replaces them with PCD references.
> 
> Ard Biesheuvel (11):
>   Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes
>   Platform/SoftIron/Overdrive1000Board: remove dead XGBE references
>   Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with
>     PCD
>   Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD
>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with
>     PCD
>   Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines
>   Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support
>   Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate
>     SSDT
>   Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with
>     PCD
>   Platform/Styx: get rid of DO_KCS preprocessor macro
>   Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon

Nice bit of cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  Silicon/AMD/Styx/AmdStyx.dec                  |  1 +
>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     | 15 +-----
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  8 ---
>  .../Overdrive1000Board/Overdrive1000Board.dsc | 10 +---
>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     |  2 -
>  .../Overdrive1000Board/Overdrive1000Board.fdf |  8 ---
>  .../AcpiPlatformDxe/AcpiPlatformDxe.inf       |  3 ++
>  .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |  1 +
>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |  2 +
>  .../Drivers/AcpiPlatformDxe/AcpiPlatform.c    | 19 +++----
>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 41 ++++++++-------
>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.c       | 50 ++++++++-----------
>  .../AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 25 ----------
>  .../Styx/Drivers/AcpiPlatformDxe/Iort.aslc    |  8 ---
>  .../Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl  | 47 +++++++++++++++++
>  15 files changed, 108 insertions(+), 132 deletions(-)
>  create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl
> 
> -- 
> 2.19.2
> 


  parent reply	other threads:[~2018-12-12 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 18:35 [PATCH edk2-platforms 00/11] final set of Styx cleanups Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 01/11] Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 02/11] Platform/SoftIron/Overdrive1000Board: remove dead XGBE references Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 03/11] Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with PCD Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 04/11] Silicon/AMD/Styx/PlatInitPei: " Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 05/11] Silicon/AMD/Styx/StyxDtbLoaderLib: " Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 06/11] Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 07/11] Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 08/11] Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate SSDT Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 09/11] Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with PCD Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 10/11] Platform/Styx: get rid of DO_KCS preprocessor macro Ard Biesheuvel
2018-12-11 18:35 ` [PATCH edk2-platforms 11/11] Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon Ard Biesheuvel
2018-12-12 22:23 ` Leif Lindholm [this message]
2018-12-13 11:09   ` [PATCH edk2-platforms 00/11] final set of Styx cleanups Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212222319.qhf27cxz5liuqprq@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox