From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5DC592119C8B0 for ; Wed, 12 Dec 2018 14:23:23 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id n190so443786wmd.0 for ; Wed, 12 Dec 2018 14:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IBQ/Hvj2P6/0FPjzuZ1ql2GDbC1v4WA3CN2Uza2Eg0Y=; b=UY7VlM6/wIW6iQv4P2c7qIpI8bLx12YBXDv2em0y03L9fWA4y1nUNrOtqTq1pPCxqR q6rGGENvZYy6iTR7JdKvG6irszimyDoh4N1CqmSykYr2PRZ8cK3hBRSOhU1PcbEbKuBN /+9Y2cF4BEgpZeeIM89E6BCVKL3sfTv8eXVR0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IBQ/Hvj2P6/0FPjzuZ1ql2GDbC1v4WA3CN2Uza2Eg0Y=; b=cWzjCu1L4bh7ZTjbj9DFeiEFR2FJYjkETjb30bSdcz5FTV1k1SuG8JypZ4CBITlFHh HAFPUKuuEYnnd40UXQqRBD1OWYhTltsJQiZKGrDdPwXIi6mnEZOFpYIm/LEHx0Rqzf+E BquqIHKaGjaskNtQtRuiom+74P7xryUHdZ2iFVAc7EdUw7rf7ivbIle0Bn2YJD4TMhfw siakJ2bnMbDwyGPwQp7HWbwcH+ZUeaNNDkx/g1Ra8RjPfXG/7AtYM+iqJjKwpEDENUUX 1WSeCkr/XH/F09SfpOvxLAXsS/FRRIUsMQhDNZxPs5B5nv+DvHUTZnZ6NTfiWw5t81Su MIiQ== X-Gm-Message-State: AA+aEWZz+CghtWJQ5/fODsc0I8Qfc4xLE28UVXFHqafi/sjbSfqYCF9u NMGQCxMDcXYmJ5Kr3Hi5GvxC1A== X-Google-Smtp-Source: AFSGD/UdpTUyOKCizspyMO06EceJBXbpU5bAKMOY3mBuwoUl8igcZcA81nIZJbrXnkv+wDmKQ3IS6g== X-Received: by 2002:a1c:ac85:: with SMTP id v127mr7156933wme.62.1544653401814; Wed, 12 Dec 2018 14:23:21 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j14sm3880wrv.96.2018.12.12.14.23.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 14:23:20 -0800 (PST) Date: Wed, 12 Dec 2018 22:23:19 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, alan@softiron.co.uk Message-ID: <20181212222319.qhf27cxz5liuqprq@bivouac.eciton.net> References: <20181211183514.20948-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181211183514.20948-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 00/11] final set of Styx cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 22:23:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote: > I promise :-) Yeah, right :) > This gets rid of the last build config options passed via the command > line into the preprocessor, and replaces them with PCD references. > > Ard Biesheuvel (11): > Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes > Platform/SoftIron/Overdrive1000Board: remove dead XGBE references > Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with > PCD > Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD > Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with > PCD > Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines > Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support > Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate > SSDT > Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with > PCD > Platform/Styx: get rid of DO_KCS preprocessor macro > Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon Nice bit of cleanup. Reviewed-by: Leif Lindholm > Silicon/AMD/Styx/AmdStyx.dec | 1 + > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 15 +----- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 8 --- > .../Overdrive1000Board/Overdrive1000Board.dsc | 10 +--- > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 2 - > .../Overdrive1000Board/Overdrive1000Board.fdf | 8 --- > .../AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 ++ > .../Styx/Drivers/PlatInitPei/PlatInitPei.inf | 1 + > .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 + > .../Drivers/AcpiPlatformDxe/AcpiPlatform.c | 19 +++---- > .../Styx/Drivers/PlatInitPei/PlatInitPei.c | 41 ++++++++------- > .../StyxDtbLoaderLib/StyxDtbLoaderLib.c | 50 ++++++++----------- > .../AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 25 ---------- > .../Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 8 --- > .../Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl | 47 +++++++++++++++++ > 15 files changed, 108 insertions(+), 132 deletions(-) > create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtKcs.asl > > -- > 2.19.2 >