public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Shenglei Zhang <shenglei.zhang@intel.com>
Cc: edk2-devel@lists.01.org,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 0/2] Add two public functions
Date: Thu, 13 Dec 2018 10:51:49 +0000	[thread overview]
Message-ID: <20181213105149.qmycz7eshvai67r7@bivouac.eciton.net> (raw)
In-Reply-To: <20181213083439.28716-1-shenglei.zhang@intel.com>

Please let the subject line give some sort of hint of what is being
done, and to what. "Add two functions" is not substantially more
descriptive than "add 572 characters".

In this case, your're moving previously internal string helper functions
to BaseLib.

On Thu, Dec 13, 2018 at 04:34:37PM +0800, Shenglei Zhang wrote:
> Add two public functions,CharToUpper and AsciiToUpper,and
> remove the same functional functions,InternalCharToUpper
> and InternalBaseLibAsciiToUpper.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Shenglei Zhang (2):
>   MdePkg/BaseLib: Add two public functions
>   BaseTools/Common: Remove InternalCharToUpper
> 
>  BaseTools/Source/C/Common/CommonLib.c     | 16 ++-------
>  BaseTools/Source/C/Common/CommonLib.h     |  4 ---
>  MdePkg/Include/Library/BaseLib.h          | 40 +++++++++++++++++++++
>  MdePkg/Library/BaseLib/BaseLibInternals.h | 42 -----------------------
>  MdePkg/Library/BaseLib/SafeString.c       |  8 ++---
>  MdePkg/Library/BaseLib/String.c           | 35 ++++---------------
>  6 files changed, 53 insertions(+), 92 deletions(-)
> 
> -- 
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2018-12-13 10:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  8:34 [PATCH 0/2] Add two public functions Shenglei Zhang
2018-12-13  8:34 ` [PATCH 1/2] MdePkg/BaseLib: " Shenglei Zhang
2018-12-13 10:33   ` Laszlo Ersek
2018-12-13 10:49   ` Leif Lindholm
2018-12-13  8:34 ` [PATCH 2/2] BaseTools/Common: Remove InternalCharToUpper Shenglei Zhang
2018-12-13 10:51 ` Leif Lindholm [this message]
2018-12-14  6:17   ` [PATCH 0/2] Add two public functions Zhang, Shenglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213105149.qmycz7eshvai67r7@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox