From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7AB52119FF57 for ; Thu, 13 Dec 2018 02:51:53 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id f81so1865575wmd.4 for ; Thu, 13 Dec 2018 02:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jaCNnkooSenRV08Oe6q8umkb08jAzUvVAaR86IDhdeQ=; b=DvoeiWDicDcDbgcwqPnngMIixYp0L44ROPmRe4Yoc2igWijqc91IdOy1td7/s788xF IwxM+e0l0zJ0T6sk62kBP/3kTy6Un/MWwyHIwvfuwWJ/F0Kd1Ro0wDEzzP19PXBet5Vk CDGjjlnIGDid+LS/SRw/b7/x4jPKJmIMMG7c4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jaCNnkooSenRV08Oe6q8umkb08jAzUvVAaR86IDhdeQ=; b=LGSvid5x2iYWxKVaV60OZyQNHRqyybCF0zDiqmS3qERHOW95fWplprE4veJE8b+CmE ux3SiJTu9spQVEQlghSkIMX9gqOtOFcmfD33XUz6N+Gqen5BEl7u7FY06gc1ALpEPwjH nZJSygN7ytp477jmAUQt633uQfaUBwl60en9adbCXRMgJFuui9LcxocwAqZxfWeIapIl TLiYC4XVJ6+EP5c7H+IVjE0VtyLEwM5Qj6BGCPQV5n8CirnsbSdRNBQW7YrYHpL41mBX S2Y9rrxFZHl6ylcblG+pFno9NGRCo7m7kecsV3O92HDtpkPKpuau+E+CeBTYqlnR3ypH sxPg== X-Gm-Message-State: AA+aEWb9nr0aIbkBiTyL8Bd6vQnyiUSZZ/SfNCLeWT1iNjtKGPAJ8FrZ YO71EUIdUpkHcJ6JKojzVJN2ajFGCVo= X-Google-Smtp-Source: AFSGD/V3s6dWFpG2xsZd6y6i05ED3HOaEd6aLCaY+NB6Z1YDJ0vWodozv5iYbUtlcGk+J9G7G+gYZA== X-Received: by 2002:a1c:c2d5:: with SMTP id s204mr10445728wmf.144.1544698311834; Thu, 13 Dec 2018 02:51:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 129sm1761709wmd.18.2018.12.13.02.51.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 02:51:51 -0800 (PST) Date: Thu, 13 Dec 2018 10:51:49 +0000 From: Leif Lindholm To: Shenglei Zhang Cc: edk2-devel@lists.01.org, Michael D Kinney , Liming Gao Message-ID: <20181213105149.qmycz7eshvai67r7@bivouac.eciton.net> References: <20181213083439.28716-1-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20181213083439.28716-1-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/2] Add two public functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 10:51:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Please let the subject line give some sort of hint of what is being done, and to what. "Add two functions" is not substantially more descriptive than "add 572 characters". In this case, your're moving previously internal string helper functions to BaseLib. On Thu, Dec 13, 2018 at 04:34:37PM +0800, Shenglei Zhang wrote: > Add two public functions,CharToUpper and AsciiToUpper,and > remove the same functional functions,InternalCharToUpper > and InternalBaseLibAsciiToUpper. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Bob Feng > Cc: Yonghong Zhu > Shenglei Zhang (2): > MdePkg/BaseLib: Add two public functions > BaseTools/Common: Remove InternalCharToUpper > > BaseTools/Source/C/Common/CommonLib.c | 16 ++------- > BaseTools/Source/C/Common/CommonLib.h | 4 --- > MdePkg/Include/Library/BaseLib.h | 40 +++++++++++++++++++++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ----------------------- > MdePkg/Library/BaseLib/SafeString.c | 8 ++--- > MdePkg/Library/BaseLib/String.c | 35 ++++--------------- > 6 files changed, 53 insertions(+), 92 deletions(-) > > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel