From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1098:0:80:1000:c:0:1; helo=cavan.codon.org.uk; envelope-from=prvs=0886dac7c2=mjg59@cavan.codon.org.uk; receiver=edk2-devel@lists.01.org Received: from cavan.codon.org.uk (cavan.codon.org.uk [IPv6:2a00:1098:0:80:1000:c:0:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22F68211A1E55 for ; Fri, 14 Dec 2018 02:22:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codon.org.uk; s=63138784; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ks+PFzXgnOA99GypM1YExHb1BGnIXRmuHcS7BMT2buE=; b=fbvvDvwQQ8ehiKy+Y1vjDglqm wONsTO5ImceMLDcSRDgyIEaGFIo1z6oAhmAe73VkblJcENWDkUutmdnXU661e6wg0quavYmEUiK0N wUPsiFDyumjU4uUle3FDUGhEt9CHCZdGnrdU5H9zzUnhVAaOjMmwlgV8Uya/NP0H6xPnY=; Received: from mjg59 by cavan.codon.org.uk with local (Exim 4.89) (envelope-from ) id 1gXkcA-0007Ky-Di; Fri, 14 Dec 2018 10:22:38 +0000 Date: Fri, 14 Dec 2018 10:22:38 +0000 From: Matthew Garrett To: Laszlo Ersek Cc: edk2-devel@lists.01.org, Jiewen Yao , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stefan Berger Message-ID: <20181214102238.7hwrfj5dwxndphyy@srcf.ucam.org> References: <20181213011750.bfzfyhrr4ufsiu6j@srcf.ucam.org> <20181213185502.lytmgkpl5u3flyyp@srcf.ucam.org> <4473c61d-6b34-b974-0d42-ec4bd51fb6db@redhat.com> MIME-Version: 1.0 In-Reply-To: <4473c61d-6b34-b974-0d42-ec4bd51fb6db@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Subject: Re: Obtaining TCG final events on systems without TCG2 log support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 10:22:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 14, 2018 at 10:32:29AM +0100, Laszlo Ersek wrote: > On 12/13/18 19:55, Matthew Garrett wrote: > > If a platform is unable to produce them in the final events table then > > it's violating the spec. > > The question is why it's made impossible to comply with the spec if the > platform only supports the 1.2 format. If a platform can't implement the spec then the platform violates the spec :) > > If the platform only offers the 1.2 log format > > then it seems reasonable to expect that the events in the final events > > table would only contain a SHA1, but a TCG_PCR_EVENT2 structure that > > only contains SHA1s isn't significantly more complicated than an old > > style event. > > > > OK... I guess that can be a valid interpretation. Would you please file > a TianoCore BZ ticket about it, as a feature request? Will do. > (I'm assuming this isn't a regression, i.e., it's not the case that the > feature used to work, but commit fd46e831bc33 regressed it.) It looks like fd46e831bc33 didn't change anything significant here, so I don't think this is a regression. -- Matthew Garrett | mjg59@srcf.ucam.org