* [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides
@ 2018-12-15 8:33 Ard Biesheuvel
2018-12-15 11:03 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-15 8:33 UTC (permalink / raw)
To: edk2-devel
Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS
for that. Also, setting -mfpu=neon is not entirely inappropriate, since
NEON is not mandatory under v7.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/ArmPkg.dsc | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 495f13d2bbec..5d83c18b143e 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -31,9 +31,6 @@
SKUID_IDENTIFIER = DEFAULT
[BuildOptions]
- XCODE:*_*_ARM_PLATFORM_FLAGS == -arch armv7
- GCC:*_*_ARM_PLATFORM_FLAGS == -march=armv7-a -mfpu=neon
-
RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides
2018-12-15 8:33 [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides Ard Biesheuvel
@ 2018-12-15 11:03 ` Leif Lindholm
2018-12-15 18:16 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-12-15 11:03 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Sat, Dec 15, 2018 at 09:33:08AM +0100, Ard Biesheuvel wrote:
> Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS
> for that. Also, setting -mfpu=neon is not entirely inappropriate, since
> NEON is not mandatory under v7.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmPkg/ArmPkg.dsc | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 495f13d2bbec..5d83c18b143e 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -31,9 +31,6 @@
> SKUID_IDENTIFIER = DEFAULT
>
> [BuildOptions]
> - XCODE:*_*_ARM_PLATFORM_FLAGS == -arch armv7
> - GCC:*_*_ARM_PLATFORM_FLAGS == -march=armv7-a -mfpu=neon
> -
> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides
2018-12-15 11:03 ` Leif Lindholm
@ 2018-12-15 18:16 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-15 18:16 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Sat, 15 Dec 2018 at 12:03, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Sat, Dec 15, 2018 at 09:33:08AM +0100, Ard Biesheuvel wrote:
> > Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS
> > for that. Also, setting -mfpu=neon is not entirely inappropriate, since
> > NEON is not mandatory under v7.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 48e890457b06..0a538ddab43f
> > ---
> > ArmPkg/ArmPkg.dsc | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> > index 495f13d2bbec..5d83c18b143e 100644
> > --- a/ArmPkg/ArmPkg.dsc
> > +++ b/ArmPkg/ArmPkg.dsc
> > @@ -31,9 +31,6 @@
> > SKUID_IDENTIFIER = DEFAULT
> >
> > [BuildOptions]
> > - XCODE:*_*_ARM_PLATFORM_FLAGS == -arch armv7
> > - GCC:*_*_ARM_PLATFORM_FLAGS == -march=armv7-a -mfpu=neon
> > -
> > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> > *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
> >
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-15 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-15 8:33 [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides Ard Biesheuvel
2018-12-15 11:03 ` Leif Lindholm
2018-12-15 18:16 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox