From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F2C00211A45A6 for ; Sat, 15 Dec 2018 03:03:22 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id a62so7937558wmh.4 for ; Sat, 15 Dec 2018 03:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rtyhKU0R/oHBvP8KolKfzfmJiQWLGXNwopGIAeLepIg=; b=SzVxiUcG6XiYqRgc1202AAjJuQ0+m5tFxG0AoceL9jY2xnS+bL3NmokLzdt6BxlRie 2iG7LPSY+TuZQLTJMiCKE5RVhXiPVEVkbZLy7ILLNmvSIfM699OwkzAJfsHeCyndf+sT r7tOq03ofeJjMXWCioo81DbjoAEbrAYENRvk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rtyhKU0R/oHBvP8KolKfzfmJiQWLGXNwopGIAeLepIg=; b=uahQnJjfAz/wxUrVd2Mu5BlL/SdWp+5oAYDhpS2/j8/k3JZ0l8HTxo7ypAWk6MDeAl AqzPZ7oQ8fujm5RvwKTLUXaY+61ZyuzsI8RB8z1ADiIBIoK6vsunROI5cfF7UBN+Jabf c0tALM6pcwW+YCaqjX6g43Ia8dTadBiP0+rE8aRLmUwx14W4iitwzWrJHUsBHOlyXUNZ s/WiJyUNVONcVCAK76rLJArkeAtXKktLBS/1Y424kW9aCPpSMf6vNJENkx7dVZubRhOj 7y25gAyouvohoLlGesI2w+bzRGUWxeFWWxTXfqzrWIP7hwu+78YqgHVo2gl0pzcX5YUl tjoQ== X-Gm-Message-State: AA+aEWYz1jkTbOzOqal0LtldOJVKGDcUO6mwfrtCLcnSeVF9nl9fym2n fBUmjZP3IBqRyHEvSifz5yNX6Q== X-Google-Smtp-Source: AFSGD/UQeVTETKy0022e3zC0yej/ZDYow22/xe9QWS82k2HFLldGLH1gFMSdrWM9kQE2EiTa+bayUg== X-Received: by 2002:a1c:91d1:: with SMTP id t200mr5962397wmd.111.1544871800542; Sat, 15 Dec 2018 03:03:20 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a12sm8820904wro.18.2018.12.15.03.03.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Dec 2018 03:03:19 -0800 (PST) Date: Sat, 15 Dec 2018 11:03:17 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20181215110317.z6badq2nzzas5wjy@bivouac.eciton.net> References: <20181215083308.15038-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181215083308.15038-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2018 11:03:23 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Dec 15, 2018 at 09:33:08AM +0100, Ard Biesheuvel wrote: > Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS > for that. Also, setting -mfpu=neon is not entirely inappropriate, since > NEON is not mandatory under v7. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dsc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 495f13d2bbec..5d83c18b143e 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -31,9 +31,6 @@ > SKUID_IDENTIFIER = DEFAULT > > [BuildOptions] > - XCODE:*_*_ARM_PLATFORM_FLAGS == -arch armv7 > - GCC:*_*_ARM_PLATFORM_FLAGS == -march=armv7-a -mfpu=neon > - > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > > -- > 2.17.1 >