Re: [PATCH edk2-platforms 27/27] Platform/Solidrun: Add i.MX 6Quad Hummingboard Edge dsc and fdf files

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Sep 21, 2018 at 08:26:19AM +0000, Chris Co wrote:
> This adds the dsd and fdf definitions for Solidrun's i.MX 6Quad
> Hummingboard Edge platform.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co <christopher.co@microsoft.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc | 141 ++++++++++++++++++++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf | 117 ++++++++++++++++
>  2 files changed, 258 insertions(+)
> 
> diff --git a/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc b/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc
> new file mode 100644
> index 000000000000..5e203bc92447
> --- /dev/null
> +++ b/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc
> @@ -0,0 +1,141 @@
> +#
> +# HummingBoard Edge board description
> +# The board is iMX6 Quad with 2GB DRAM
> +#
> +#  Copyright (c) 2018 Microsoft Corporation. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +
> +################################################################################
> +#
> +# Board [Defines] Section
> +#
> +################################################################################
> +
> +[Defines]
> +  DEFINE BOARD_NAME     = HummingBoardEdge_iMX6Q_2GB
> +  DEFINE IMX_FAMILY     = IMX6DQ
> +  DEFINE IMX_CHIP_TYPE  = QUAD
> +  DEFINE DRAM_SIZE      = DRAM_2GB
> +  BOARD_DIR             = Platform/SolidRun/$(BOARD_NAME)
> +  FLASH_DEFINITION      = $(BOARD_DIR)/$(BOARD_NAME).fdf
> +
> +################################################################################
> +#
> +# Platform Description
> +#
> +################################################################################
> +!include Silicon/NXP/iMX6Pkg/iMX6CommonDsc.inc
> +
> +[LibraryClasses.common]
> +  ArmPlatformLib|$(BOARD_DIR)/Library/iMX6BoardLib/iMX6BoardLib.inf
> +
> +[Components.common]
> +  # Display Support
> +!if $(CONFIG_HEADLESS) == FALSE
> +  MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
> +  MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> +  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
> +  !if $(IMX_FAMILY) == IMX6SX
> +    #
> +    # Use board-specific GOP for SoloX
> +    #
> +    $(BOARD_DIR)/Drivers/GraphicsOutputDxe/GraphicsOutputDxe.inf
> +  !else
> +    Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.inf
> +  !endif
> +!endif
> +
> +  # ACPI Support
> +  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> +  MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf
> +  $(BOARD_DIR)/AcpiTables/AcpiTables.inf
> +
> +  # SMBIOS Support
> +  Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
> +  MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> +
> +################################################################################
> +#
> +# Board PCD Sections
> +#
> +################################################################################
> +
> +########################
> +#
> +# iMX6Pkg PCDs
> +#
> +########################
> +[PcdsFixedAtBuild.common]
> +
> +# SMBIOS Type0 Strings
> +gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"SolidRun"

Could you do a
!ifdef $(FIRMWARE_VENDOR)
  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"$(FIRMWARE_VENDOR)"
!else
  whatever
!endif
?

> +gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision|0x00000001 # FirmwareRevision 0.1

And the same for FIRMWARE_VER?

/
    Leif


> +
> +# SMBIOS Type1 Strings
> +giMX6TokenSpaceGuid.PcdSystemFamily|L"HummingBoard"
> +giMX6TokenSpaceGuid.PcdSystemManufacturer|L"SolidRun"
> +giMX6TokenSpaceGuid.PcdSystemProductName|L"HummingBoard-Edge i4Pro"
> +giMX6TokenSpaceGuid.PcdSystemSkuNumber|L"MSMX6QDW00D02GE008E00CH"
> +giMX6TokenSpaceGuid.PcdSystemVersionNumber|L"1.4"
> +giMX6TokenSpaceGuid.PcdSystemUuid|{0xfa,0x00,0xe9,0x0f,0x97,0x4a,0x40,0x6f,0xaf,0x0f,0x4a,0xd4,0x66,0x50,0xbe,0x5a}
> +
> +# SMBIOS Type2 Strings
> +giMX6TokenSpaceGuid.PcdBoardAssetTag|L"0"
> +giMX6TokenSpaceGuid.PcdBoardLocationInChassis|L"Open Board"
> +giMX6TokenSpaceGuid.PcdBoardManufacturer|L"SolidRun"
> +giMX6TokenSpaceGuid.PcdBoardProductName|L"HummingBoard-Edge i4Pro"
> +giMX6TokenSpaceGuid.PcdBoardVersionNumber|L"1.4"
> +
> +# SMBIOS Type3 Strings
> +giMX6TokenSpaceGuid.PcdChassisAssetTag|L"0"
> +giMX6TokenSpaceGuid.PcdChassisManufacturer|L"SolidRun"
> +giMX6TokenSpaceGuid.PcdChassisVersionNumber|L"1.4"
> +
> +# SMBIOS Type4 Strings
> +giMX6TokenSpaceGuid.PcdProcessorAssetTag|L"0"
> +giMX6TokenSpaceGuid.PcdProcessorManufacturer|L"NXP"
> +giMX6TokenSpaceGuid.PcdProcessorPartNumber|L"i.MX 6Quad"
> +giMX6TokenSpaceGuid.PcdProcessorSocketDesignation|L"FCPBGA"
> +giMX6TokenSpaceGuid.PcdProcessorVersionNumber|L"1.0"
> +
> +# SMBIOS Type16
> +giMX6TokenSpaceGuid.PcdPhysicalMemoryMaximumCapacity|0x200000 # 2GB
> +
> +# SMBIOS Type17
> +giMX6TokenSpaceGuid.PcdMemoryBankLocation|L"Bank 0"
> +giMX6TokenSpaceGuid.PcdMemoryDeviceLocation|L"On SoM"
> +
> +#
> +# USB EHCI Controller (USB_UH1)
> +#
> +giMX6TokenSpaceGuid.PcdEHCIBase|0x02184200
> +
> +#
> +# Enable uSDHC2 and uSDHC3 Controllers.
> +# On HummingBoardEdge, SDCard slot is attached to uSDHC2
> +# with CD wired to SD2_CD_B, eMMC is attached to uSDHC3
> +#
> +giMXPlatformTokenSpaceGuid.PcdSdhc2Enable|TRUE
> +giMXPlatformTokenSpaceGuid.PcdSdhc2CardDetectSignal|0xFFFF # Use uSDHC internal CD circuit
> +giMXPlatformTokenSpaceGuid.PcdSdhc3Enable|TRUE
> +
> +#
> +# UART initialization required
> +#
> +giMXPlatformTokenSpaceGuid.PcdSerialRegisterBase|0x02020000   # UART1
> +giMXPlatformTokenSpaceGuid.PcdKdUartInstance|1                # UART1
> +
> +#
> +# GPIO reset pin (PERST)
> +#
> +giMX6TokenSpaceGuid.PcdPcieResetGpio|TRUE
> +giMX6TokenSpaceGuid.PcdPcieResetGpioBankNumber|2
> +giMX6TokenSpaceGuid.PcdPcieResetGpioIoNumber|11
> diff --git a/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf b/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf
> new file mode 100644
> index 000000000000..f40ee824e1e3
> --- /dev/null
> +++ b/Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf
> @@ -0,0 +1,117 @@
> +#
> +#  iMX6 Quad Hummingboard FLASH layout
> +#
> +#  Copyright (c) 2018 Microsoft Corporation. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +
> +################################################################################
> +#
> +# FD Section
> +# The [FD] Section is made up of the definition statements and a
> +# description of what goes into  the Flash Device Image.  Each FD section
> +# defines one flash "device" image.  A flash device image may be one of
> +# the following: Removable media bootable image (like a boot floppy
> +# image,) an Option ROM image (that would be "flashed" into an add-in
> +# card,) a System "Flash"  image (that would be burned into a system's
> +# flash) or an Update ("Capsule") image that will be used to update and
> +# existing system flash.
> +#
> +################################################################################
> +
> +[FD.iMXBoard_EFI]
> +!if $(IMX_FAMILY) == IMX6SX
> +BaseAddress   = 0x82004000|gArmTokenSpaceGuid.PcdFdBaseAddress  #The base address of UEFI image
> +!else
> +BaseAddress   = 0x10820000|gArmTokenSpaceGuid.PcdFdBaseAddress  #The base address of UEFI image
> +!endif
> +Size          = 0x001D0000|gArmTokenSpaceGuid.PcdFdSize         #The size in bytes of UEFI image
> +ErasePolarity = 1
> +BlockSize     = 0x1
> +NumBlocks     = 0x001D0000
> +
> +################################################################################
> +#
> +# Following are lists of FD Region layout which correspond to the locations of different
> +# images within the flash device.
> +#
> +# Regions must be defined in ascending order and may not overlap.
> +#
> +# A Layout Region start with a eight digit hex offset (leading "0x" required) followed by
> +# the pipe "|" character, followed by the size of the region, also in hex with the leading
> +# "0x" characters. Like:
> +# Offset|Size
> +# PcdOffsetCName|PcdSizeCName
> +# RegionType <FV, DATA, or FILE>
> +#
> +################################################################################
> +0x00000000|0x001D0000    # 1792Kb for the Pei phase boot
> +
> +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
> +FV = FVMAIN_COMPACT
> +
> +################################################################################
> +#
> +# FV Section
> +#
> +# [FV] section is used to define what components or modules are placed within a flash
> +# device file.  This section also defines order the components and modules are positioned
> +# within the image.  The [FV] section consists of define statements, set statements and
> +# module statements.
> +#
> +################################################################################
> +[FV.FvMain]
> +BlockSize          = 0x1
> +NumBlocks          = 0         # This FV gets compressed so make it just big enough
> +FvAlignment        = 8         # FV alignment and FV attributes setting.
> +ERASE_POLARITY     = 1
> +MEMORY_MAPPED      = TRUE
> +STICKY_WRITE       = TRUE
> +LOCK_CAP           = TRUE
> +LOCK_STATUS        = TRUE
> +WRITE_DISABLED_CAP = TRUE
> +WRITE_ENABLED_CAP  = TRUE
> +WRITE_STATUS       = TRUE
> +WRITE_LOCK_CAP     = TRUE
> +WRITE_LOCK_STATUS  = TRUE
> +READ_DISABLED_CAP  = TRUE
> +READ_ENABLED_CAP   = TRUE
> +READ_STATUS        = TRUE
> +READ_LOCK_CAP      = TRUE
> +READ_LOCK_STATUS   = TRUE
> +
> +  #
> +  # ACPI
> +  #
> +  INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> +  INF MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf
> +  INF RuleOverride=ACPITABLE $(BOARD_DIR)/AcpiTables/AcpiTables.inf
> +
> +!if $(CONFIG_HEADLESS) == FALSE
> +  INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
> +  INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> +  INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
> +  !if $(IMX_FAMILY) == IMX6SX
> +    #
> +    # Use board-specific GOP for SoloX
> +    #
> +    INF $(BOARD_DIR)/Drivers/GraphicsOutputDxe/GraphicsOutputDxe.inf
> +  !else
> +    INF Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.inf
> +  !endif
> +!endif
> +
> +  #
> +  # SMBIOS Support
> +  #
> +  INF Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
> +  INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> +
> +!include Silicon/NXP/iMX6Pkg/iMX6CommonFdf.inc
> -- 
> 2.16.2.gvfs.1.33.gf5370f1
>