public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Chris Co <Christopher.Co@microsoft.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH edk2-platforms 00/27] Import Hummingboard Edge platform for Windows IoT Core
Date: Sat, 15 Dec 2018 13:32:08 +0000	[thread overview]
Message-ID: <20181215133208.sukfxdhwlxaswnqz@bivouac.eciton.net> (raw)
In-Reply-To: <20180921082542.35768-1-christopher.co@microsoft.com>

Hi Chris,

Sorry for dragging this out, but it's been a crazy year.
I think I've now provided feedback for all but the SdMmc bits.

For the next revision, please break out SdMmc support (including and put it last
in the series). I still don't like the idea of adding a third driver
stack to the project, and am likely to have ideas of major
restructuring, but if we can isolate that from the rest, reviewing the
remainder should be reasonably quick next time around.

My last day "in the office" before Christmas is 21 December, and then
I'll be out until 7 January. So basically, if you can get a new set
out early nexy week, I may have a chance to look at it, and if not -
take your time :)

Regards,

Leif

On Fri, Sep 21, 2018 at 08:25:52AM +0000, Chris Co wrote:
> REF: https://github.com/christopherco/edk2-platforms/tree/winiot_hmb_v1
> 
> v0:
> * https://lists.01.org/pipermail/edk2-devel/2018-July/027213.html
> * https://lists.01.org/pipermail/edk2-devel/2018-July/027266.html
> * https://lists.01.org/pipermail/edk2-devel/2018-July/027333.html
> * https://lists.01.org/pipermail/edk2-devel/2018-July/027409.html
> 
> The patch set supports the bring up of Windows 10 IoT Core on
> Solidrun's Hummingboard Edge board running NXP's i.MX 6Quad SoC.
> 
> This patch set is a preliminary submission, with the goal to get further review
> feedback from maintainers since the v0 version had too many initial issues to
> conduct a full review.
> 
> Changes in this patch set from v0:
> * Merged the 4 previous patch sets into one.
> * All code should now follow the edk2 coding style.
> * SMBIOS driver refactored to use PCDs. Fixed UUID generation to use MAC address.
> * Updated ACPI HIDs to proper NXP IDs where applicable.
> * Removed unnecessary (and spec-violating) _DSD methods from our ACPI tables.
> * General code cleanup and refactoring.
> * Add Silicon package support for i.MX 6Solo/DualLite, 6SoloX, 6DualPlus/QuadPlus
> families in iMX6Pkg.
> 
> Known issues remaining from previous review:
> * Silicon/NXP/iMXPlatformPkg: SdhcDxe fixed initialization needs to be moved to
> a PlatformDxe init and use NonDiscoverableDeviceRegistrationLib.
> * Platform/Microsoft: Left in SdMmcDxe code. Alternatives are still under
> evaluation.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co <christopher.co@microsoft.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Christopher Co (27):
>   Platform/Microsoft: Add OpteeClientPkg dec
>   Platform/Microsoft: Add SdMmc Dxe Driver
>   Platform/Microsoft: Add MsPkg
>   Silicon/NXP: Add iMXPlatformPkg dec
>   Silicon/NXP: Add UART library support for i.MX platforms
>   Silicon/NXP: Add I2C library support for i.MX platforms
>   Silicon/NXP: Add i.MX display library support
>   Silicon/NXP: Add Virtual RTC support for i.MX platform
>   Silicon/NXP: Add headers for SoC-specific i.MX packages to use
>   Silicon/NXP: Add iMX6Pkg dec
>   Silicon/NXP: Add i.MX6 SoC header files
>   Silicon/NXP: Add i.MX6 I/O MUX library
>   Silicon/NXP: Add support for iMX SDHC
>   Silicon/NXP: Add i.MX6 GPT and EPIT timer headers
>   Silicon/NXP: Add i.MX6 GPT Timer library
>   Silicon/NXP: Add i.MX6 Timer DXE driver
>   Silicon/NXP: Add i.MX6 USB Phy Library
>   Silicon/NXP: Add i.MX6 Clock Library
>   Silicon/NXP: Add i.MX6 ACPI tables
>   Silicon/NXP: Add i.MX6 Board init library
>   Silicon/NXP: Add i.MX6 PCIe DXE driver
>   Silicon/NXP: Add i.MX6 GOP driver
>   Silicon/NXP: Add i.MX6 Smbios Driver
>   Silicon/NXP: Add i.MX6 common dsc and fdf files
>   Platform/Solidrun: Add Hummingboard Peripheral Initialization
>   Platform/SolidRun: Add i.MX 6Quad Hummingboard Edge ACPI tables
>   Platform/Solidrun: Add i.MX 6Quad Hummingboard Edge dsc and fdf files
> 
>  Platform/Microsoft/Drivers/SdMmcDxe/BlockIo.c                                          |  548 +++++
>  Platform/Microsoft/Drivers/SdMmcDxe/Debug.c                                            |  363 +++
>  Platform/Microsoft/Drivers/SdMmcDxe/Protocol.c                                         | 1775 ++++++++++++++
>  Platform/Microsoft/Drivers/SdMmcDxe/Protocol.h                                         |  231 ++
>  Platform/Microsoft/Drivers/SdMmcDxe/RpmbIo.c                                           |  609 +++++
>  Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.c                                            |  886 +++++++
>  Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.h                                            |  529 +++++
>  Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf                                       |   49 +
>  Platform/Microsoft/Drivers/SdMmcDxe/SdMmcHw.h                                          |  505 ++++
>  Platform/Microsoft/Include/Protocol/RpmbIo.h                                           |  268 +++
>  Platform/Microsoft/Include/Protocol/Sdhc.h                                             |  197 ++
>  Platform/Microsoft/MsPkg.dec                                                           |   39 +
>  Platform/Microsoft/MsPkg.dsc                                                           |   31 +
>  Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec                                   |   49 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/AcpiTables.inf                 |   55 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/DSDT.asl                       |   38 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Audio.asl                 |   71 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-AudioCodec.asl            |   33 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-I2c.asl                   |   54 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Pwm.asl                   |   32 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Rhp.asl                   |  234 ++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Sdhc.asl                  |  144 ++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Spi.asl                   |   43 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Uart.asl                  |  198 ++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Usb.asl                   |  343 +++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc            |  141 ++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf            |  117 +
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.c      |  634 +++++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.h      |  705 ++++++
>  Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardLib.inf     |   91 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Csrt.aslc                                               |  408 ++++
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dbg2.aslc                                               |  142 ++
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Common.h                                           |  106 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Enet.asl                                           |  106 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Gfx.asl                                            |   74 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Gpio.asl                                           |   55 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-I2c.asl                                            |   67 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-PCIe.asl                                           |  298 +++
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Platform.asl                                       |  106 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Pwm.asl                                            |   85 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Sdhc.asl                                           |  133 ++
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Spi.asl                                            |  103 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-TrEE.asl                                           |   33 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Fadt.aslc                                               |   60 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Madt.aslc                                               |  120 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Mcfg.aslc                                               |   92 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Spcr.aslc                                               |   95 +
>  Silicon/NXP/iMX6Pkg/AcpiTables/Tpm2.aslc                                               |   53 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/CPMem.c                                             |  423 ++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/CPMem.h                                             |  277 +++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ddc.c                                               |   69 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ddc.h                                               |   28 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Display.c                                           |  455 ++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Display.h                                           |  175 ++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayController.c                                 |  399 ++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayController.h                                 |  331 +++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayInterface.c                                  |  458 ++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayInterface.h                                  |  195 ++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Edid.c                                              |   96 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Edid.h                                              |   33 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.c                                            |  475 ++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.h                                            |   20 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.inf                                          |   70 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Hdmi.c                                              |  761 ++++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Hdmi.h                                              |  529 +++++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/IoMux.c                                             |   88 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/IoMux.h                                             |   32 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ipu.h                                               |  236 ++
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Lvds.c                                              |   93 +
>  Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Lvds.h                                              |   67 +
>  Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.c                                | 1139 +++++++++
>  Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.h                                |  145 ++
>  Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.inf                              |   66 +
>  Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c                      | 1774 ++++++++++++++
>  Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.h                      |   44 +
>  Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf                    |   84 +
>  Silicon/NXP/iMX6Pkg/Drivers/TimerDxe/Timer.c                                           |  278 +++
>  Silicon/NXP/iMX6Pkg/Drivers/TimerDxe/TimerDxe.inf                                      |   55 +
>  Silicon/NXP/iMX6Pkg/Include/common_epit.h                                              |  118 +
>  Silicon/NXP/iMX6Pkg/Include/common_gpt.h                                               |  271 +++
>  Silicon/NXP/iMX6Pkg/Include/iMX6.h                                                     |   39 +
>  Silicon/NXP/iMX6Pkg/Include/iMX6BoardLib.h                                             |   55 +
>  Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr.h                                               |  105 +
>  Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_DQ.h                                            |  181 ++
>  Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_SDL.h                                           |  176 ++
>  Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_SX.h                                            |  190 ++
>  Silicon/NXP/iMX6Pkg/Include/iMX6IoMux.h                                                |  202 ++
>  Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_DQP.h                                            | 2466 ++++++++++++++++++++
>  Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_SDL.h                                            | 1875 +++++++++++++++
>  Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_SX.h                                             | 2270 ++++++++++++++++++
>  Silicon/NXP/iMX6Pkg/Include/iMX6Timer.h                                                |   24 +
>  Silicon/NXP/iMX6Pkg/Include/iMX6UsbPhy.h                                               |   20 +
>  Silicon/NXP/iMX6Pkg/Include/iMX6_DQ.h                                                  |  332 +++
>  Silicon/NXP/iMX6Pkg/Include/iMX6_DQP.h                                                 |  335 +++
>  Silicon/NXP/iMX6Pkg/Include/iMX6_SDL.h                                                 |  301 +++
>  Silicon/NXP/iMX6Pkg/Include/iMX6_SX.h                                                  | 1730 ++++++++++++++
>  Silicon/NXP/iMX6Pkg/Include/iMX6_common.h                                              | 1350 +++++++++++
>  Silicon/NXP/iMX6Pkg/Library/TimerLib/TimerLib.c                                        |  246 ++
>  Silicon/NXP/iMX6Pkg/Library/TimerLib/TimerLib.inf                                      |   45 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6BoardHelper.S                             |   89 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6BoardMem.c                                |  110 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6Common.c                                  |   88 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6QBoardCoreDef.c                           |  107 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwr.c                                 | 1876 +++++++++++++++
>  Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwrLib.inf                            |   46 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwr_private.h                         |  221 ++
>  Silicon/NXP/iMX6Pkg/Library/iMX6IoMuxLib/iMX6IoMux.c                                   |  151 ++
>  Silicon/NXP/iMX6Pkg/Library/iMX6IoMuxLib/iMX6IoMuxLib.inf                              |   41 +
>  Silicon/NXP/iMX6Pkg/Library/iMX6UsbPhyLib/iMX6UsbPhy.c                                 |  328 +++
>  Silicon/NXP/iMX6Pkg/Library/iMX6UsbPhyLib/iMX6UsbPhyLib.inf                            |   43 +
>  Silicon/NXP/iMX6Pkg/iMX6CommonDsc.inc                                                  |  897 +++++++
>  Silicon/NXP/iMX6Pkg/iMX6CommonFdf.inc                                                  |  287 +++
>  Silicon/NXP/iMX6Pkg/iMX6ConfigDsc.inc                                                  |  148 ++
>  Silicon/NXP/iMX6Pkg/iMX6Pkg.dec                                                        |  143 ++
>  Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.c                                   | 1246 ++++++++++
>  Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.h                                   |   81 +
>  Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.inf                                 |   70 +
>  Silicon/NXP/iMXPlatformPkg/Include/Platform.h                                          |   67 +
>  Silicon/NXP/iMXPlatformPkg/Include/iMXDisplay.h                                        |  114 +
>  Silicon/NXP/iMXPlatformPkg/Include/iMXGpio.h                                           |   92 +
>  Silicon/NXP/iMXPlatformPkg/Include/iMXI2cLib.h                                         |  162 ++
>  Silicon/NXP/iMXPlatformPkg/Include/iMXIoMux.h                                          |   24 +
>  Silicon/NXP/iMXPlatformPkg/Include/iMXUart.h                                           |  207 ++
>  Silicon/NXP/iMXPlatformPkg/Include/iMXuSdhc.h                                          |  277 +++
>  Silicon/NXP/iMXPlatformPkg/Library/UartSerialPortLib/UartSerialPortLib.c               |  243 ++
>  Silicon/NXP/iMXPlatformPkg/Library/UartSerialPortLib/UartSerialPortLib.inf             |   41 +
>  Silicon/NXP/iMXPlatformPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c   |  227 ++
>  Silicon/NXP/iMXPlatformPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf |   37 +
>  Silicon/NXP/iMXPlatformPkg/Library/iMXDisplayLib/iMXDisplayLib.c                       |  152 ++
>  Silicon/NXP/iMXPlatformPkg/Library/iMXDisplayLib/iMXDisplayLib.inf                     |   31 +
>  Silicon/NXP/iMXPlatformPkg/Library/iMXI2cLib/iMXI2cLib.c                               |  487 ++++
>  Silicon/NXP/iMXPlatformPkg/Library/iMXI2cLib/iMXI2cLib.inf                             |   35 +
>  Silicon/NXP/iMXPlatformPkg/iMXPlatformPkg.dec                                          |  118 +
>  133 files changed, 40660 insertions(+)
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/BlockIo.c
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/Debug.c
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/Protocol.c
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/Protocol.h
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/RpmbIo.c
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.c
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.h
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf
>  create mode 100644 Platform/Microsoft/Drivers/SdMmcDxe/SdMmcHw.h
>  create mode 100644 Platform/Microsoft/Include/Protocol/RpmbIo.h
>  create mode 100644 Platform/Microsoft/Include/Protocol/Sdhc.h
>  create mode 100644 Platform/Microsoft/MsPkg.dec
>  create mode 100644 Platform/Microsoft/MsPkg.dsc
>  create mode 100644 Platform/Microsoft/OpteeClientPkg/OpteeClientPkg.dec
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/AcpiTables.inf
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/DSDT.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Audio.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-AudioCodec.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-I2c.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Pwm.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Rhp.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Sdhc.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Spi.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Uart.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Usb.asl
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.dsc
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/HummingBoardEdge_iMX6Q_2GB.fdf
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.c
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.h
>  create mode 100644 Platform/SolidRun/HummingBoardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardLib.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Csrt.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dbg2.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Common.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Enet.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Gfx.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Gpio.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-I2c.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-PCIe.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Platform.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Pwm.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Sdhc.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-Spi.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Dsdt-TrEE.asl
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Fadt.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Madt.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Mcfg.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Spcr.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/AcpiTables/Tpm2.aslc
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/CPMem.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/CPMem.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ddc.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ddc.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Display.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Display.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayController.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayController.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayInterface.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/DisplayInterface.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Edid.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Edid.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/GopDxe.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Hdmi.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Hdmi.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/IoMux.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/IoMux.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Ipu.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Lvds.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/GopDxe/Lvds.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/TimerDxe/Timer.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Drivers/TimerDxe/TimerDxe.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/common_epit.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/common_gpt.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6BoardLib.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_DQ.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_SDL.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6ClkPwr_SX.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6IoMux.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_DQP.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_SDL.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6IoMux_SX.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6Timer.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6UsbPhy.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6_DQ.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6_DQP.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6_SDL.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6_SX.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Include/iMX6_common.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/TimerLib/TimerLib.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/TimerLib/TimerLib.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6BoardHelper.S
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6BoardMem.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6Common.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6BoardLib/iMX6QBoardCoreDef.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwr.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwrLib.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6ClkPwrLib/iMX6ClkPwr_private.h
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6IoMuxLib/iMX6IoMux.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6IoMuxLib/iMX6IoMuxLib.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6UsbPhyLib/iMX6UsbPhy.c
>  create mode 100644 Silicon/NXP/iMX6Pkg/Library/iMX6UsbPhyLib/iMX6UsbPhyLib.inf
>  create mode 100644 Silicon/NXP/iMX6Pkg/iMX6CommonDsc.inc
>  create mode 100644 Silicon/NXP/iMX6Pkg/iMX6CommonFdf.inc
>  create mode 100644 Silicon/NXP/iMX6Pkg/iMX6ConfigDsc.inc
>  create mode 100644 Silicon/NXP/iMX6Pkg/iMX6Pkg.dec
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.c
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.inf
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/Platform.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXDisplay.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXGpio.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXI2cLib.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXIoMux.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXUart.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Include/iMXuSdhc.h
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/UartSerialPortLib/UartSerialPortLib.c
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/UartSerialPortLib/UartSerialPortLib.inf
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/iMXDisplayLib/iMXDisplayLib.c
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/iMXDisplayLib/iMXDisplayLib.inf
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/iMXI2cLib/iMXI2cLib.c
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/Library/iMXI2cLib/iMXI2cLib.inf
>  create mode 100644 Silicon/NXP/iMXPlatformPkg/iMXPlatformPkg.dec
> 
> -- 
> 2.16.2.gvfs.1.33.gf5370f1
> 


  parent reply	other threads:[~2018-12-15 13:32 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21  8:25 [PATCH edk2-platforms 00/27] Import Hummingboard Edge platform for Windows IoT Core Chris Co
2018-09-21  8:25 ` [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec Chris Co
2018-10-31 20:43   ` Leif Lindholm
2018-11-01 10:55     ` Sumit Garg
2018-11-02  0:41       ` Chris Co
2018-11-02  5:24         ` Sumit Garg
2018-11-02 23:55           ` Chris Co
2018-11-05 10:07             ` Sumit Garg
2018-11-06  1:53               ` Chris Co
2018-11-06 11:09                 ` Sumit Garg
2018-09-21  8:25 ` [PATCH edk2-platforms 02/27] Platform/Microsoft: Add SdMmc Dxe Driver Chris Co
2018-09-21  8:25 ` [PATCH edk2-platforms 03/27] Platform/Microsoft: Add MsPkg Chris Co
2018-10-31 21:00   ` Leif Lindholm
2018-09-21  8:25 ` [PATCH edk2-platforms 04/27] Silicon/NXP: Add iMXPlatformPkg dec Chris Co
2018-09-21  8:25 ` [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms Chris Co
2018-11-01  8:59   ` Leif Lindholm
2018-11-02  1:46     ` Chris Co
2018-09-21  8:25 ` [PATCH edk2-platforms 06/27] Silicon/NXP: Add I2C " Chris Co
2018-11-01 17:53   ` Leif Lindholm
2018-09-21  8:25 ` [PATCH edk2-platforms 07/27] Silicon/NXP: Add i.MX display library support Chris Co
2018-11-01 18:05   ` Leif Lindholm
2018-11-29  0:55     ` Chris Co
2018-09-21  8:25 ` [PATCH edk2-platforms 08/27] Silicon/NXP: Add Virtual RTC support for i.MX platform Chris Co
2018-12-15 13:26   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 10/27] Silicon/NXP: Add iMX6Pkg dec Chris Co
2018-11-01 18:25   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 09/27] Silicon/NXP: Add headers for SoC-specific i.MX packages to use Chris Co
2018-11-01 18:20   ` Leif Lindholm
2018-12-01  0:22     ` Chris Co
2018-12-03  9:42       ` Leif Lindholm
2018-12-04  1:44         ` Chris Co
2018-12-04  9:33           ` Ard Biesheuvel
2018-12-04 12:22             ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 11/27] Silicon/NXP: Add i.MX6 SoC header files Chris Co
2018-12-13 17:11   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 12/27] Silicon/NXP: Add i.MX6 I/O MUX library Chris Co
2018-11-08 18:00   ` Leif Lindholm
2018-12-04  1:41     ` Chris Co
2018-09-21  8:26 ` [PATCH edk2-platforms 13/27] Silicon/NXP: Add support for iMX SDHC Chris Co
2018-12-05 10:31   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 14/27] Silicon/NXP: Add i.MX6 GPT and EPIT timer headers Chris Co
2018-11-08 18:14   ` Leif Lindholm
2018-12-04  2:06     ` Chris Co
2018-12-04 12:58       ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 15/27] Silicon/NXP: Add i.MX6 GPT Timer library Chris Co
2018-12-13 17:26   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 16/27] Silicon/NXP: Add i.MX6 Timer DXE driver Chris Co
2018-12-13 17:33   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 17/27] Silicon/NXP: Add i.MX6 USB Phy Library Chris Co
2018-12-14 17:10   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 18/27] Silicon/NXP: Add i.MX6 Clock Library Chris Co
2018-12-14 18:12   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables Chris Co
2018-12-14 19:53   ` Leif Lindholm
2018-12-17 11:14   ` Ard Biesheuvel
2019-01-08 21:43     ` Chris Co
2019-01-29 14:09       ` Ard Biesheuvel
2018-09-21  8:26 ` [PATCH edk2-platforms 20/27] Silicon/NXP: Add i.MX6 Board init library Chris Co
2018-12-14 20:12   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 21/27] Silicon/NXP: Add i.MX6 PCIe DXE driver Chris Co
2018-12-14 21:59   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 22/27] Silicon/NXP: Add i.MX6 GOP driver Chris Co
2018-12-14 22:37   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 23/27] Silicon/NXP: Add i.MX6 Smbios Driver Chris Co
2018-12-14 23:07   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 24/27] Silicon/NXP: Add i.MX6 common dsc and fdf files Chris Co
2018-12-14 23:36   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 25/27] Platform/Solidrun: Add Hummingboard Peripheral Initialization Chris Co
2018-12-15 12:12   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 26/27] Platform/SolidRun: Add i.MX 6Quad Hummingboard Edge ACPI tables Chris Co
2018-12-15 12:19   ` Leif Lindholm
2018-09-21  8:26 ` [PATCH edk2-platforms 27/27] Platform/Solidrun: Add i.MX 6Quad Hummingboard Edge dsc and fdf files Chris Co
2018-12-15 12:28   ` Leif Lindholm
2018-12-15 13:32 ` Leif Lindholm [this message]
2018-12-19 18:28   ` [PATCH edk2-platforms 00/27] Import Hummingboard Edge platform for Windows IoT Core Chris Co

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181215133208.sukfxdhwlxaswnqz@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox