public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Alex James <theracermaster@gmail.com>
To: edk2-devel@lists.01.org
Cc: Daryl McDaniel <edk2-lists@mc2research.org>,
	Jaben Carsey <jaben.carsey@intel.com>
Subject: [PATCH v1 1/2] StdLib/sys/termios: Define cc_t as unsigned
Date: Mon, 17 Dec 2018 22:25:12 -0600	[thread overview]
Message-ID: <20181218042513.43232-2-theracermaster@gmail.com> (raw)
In-Reply-To: <20181218042513.43232-1-theracermaster@gmail.com>

According to the POSIX standard, cc_t, speed_t, and tcflag_t should be
unsigned integer types. Define cc_t as unsigned to match POSIX and fix
an implicit conversion error when building StdLib with XCODE5/CLANG38.

Cc: Daryl McDaniel <edk2-lists@mc2research.org>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Alex James <theracermaster@gmail.com>
---
 StdLib/Include/sys/termios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/StdLib/Include/sys/termios.h b/StdLib/Include/sys/termios.h
index 75886065b7..f2d60d0025 100644
--- a/StdLib/Include/sys/termios.h
+++ b/StdLib/Include/sys/termios.h
@@ -152,7 +152,7 @@ typedef enum {
 #define NOFLSH    0x0800    /* don't flush output on signal */
 #define FLUSHO    0x1000    /* output being flushed (state) */
 
-typedef INT8    cc_t;
+typedef UINT8   cc_t;
 typedef UINT16  tcflag_t;
 typedef UINT32  speed_t;
 
-- 
2.20.1



  reply	other threads:[~2018-12-18  4:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  4:25 [PATCH v1 0/2] Fix StdLib compilation with XCODE5/CLANG38 Alex James
2018-12-18  4:25 ` Alex James [this message]
2018-12-18  4:25 ` [PATCH v1 2/2] StdLib/Environs: Avoid infinite recursion in _Exit Alex James
2019-01-02 19:28   ` Carsey, Jaben
2019-01-02 19:28   ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218042513.43232-2-theracermaster@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox