From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::432; helo=mail-wr1-x432.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E2DA72119EF33 for ; Tue, 18 Dec 2018 07:24:37 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id p4so16316543wrt.7 for ; Tue, 18 Dec 2018 07:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PWpNw8BguWfBKiGRQPN9xf6ULKjtBjU/4oTYbenWnC4=; b=Sg44FuwsPwVQmsGsljEPkHRQZmjBvO4m+Z3zgP69tIMvs9/VrBaMtrqaYIcP+ApF84 4M0jsM6IWYPFXd8RIaRTYIE5GlpVKf4PlzFPMP6ARVtXQItUWLKD3asAyfSC/vU9Bo/F 5Lq6UG1eLGvLityp4+kfIp8/xiqlwJri0uXTE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PWpNw8BguWfBKiGRQPN9xf6ULKjtBjU/4oTYbenWnC4=; b=TJ+LuPevWqyFUyTeTdQjD/sEfDfIBIFIV1LlGGHGHTxjVrwv+0ugVxd5v4+gBnTlwZ VGBM6MmGHIkBQYPw2S9SbFNltj/pb3b7df9Fk49Lxhx8SvRDKNDyhjWJvAnaWR4xCj7/ m3aA5SpdQtrM+Kh/whMZnySV85qRAGvSB1Z/kmOGKYt04FuHNOi6shljrq60VtX2VkA7 RK5UJj0khdOhAMsI9Htnkhs9zmFt4L5FDIZ39TenIzOjtuL40VuOzP9mgZnArj6kVPwV KvsYblQDoc09bw1GNepmdgGglSq3iFMVnTixPuFkR1x1jvIO3sHJP0n6py9+hvAAPvJj Wsyg== X-Gm-Message-State: AA+aEWYCF4/D+tgG7rsOIemFDfvJU34j98TOJt2KIZ5u+kC6GkdcN7F4 bMQOqLHB5CWIjKoUw2g2uQiUcA== X-Google-Smtp-Source: AFSGD/UZTa+MUsuUay51DBnBEcd+JGe7z7RWgO9I4NBB3GrW+aDIFXBB5KvsQx6zMeCwc3F04SxdIA== X-Received: by 2002:adf:900f:: with SMTP id h15mr14964882wrh.18.1545146676228; Tue, 18 Dec 2018 07:24:36 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a18sm6841897wrp.13.2018.12.18.07.24.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 07:24:35 -0800 (PST) Date: Tue, 18 Dec 2018 15:24:33 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Sami Mujawar , Thomas Panakamattam Abraham , Meenakshi Aggarwal , Udit Kumar , Matteo Carlini , Nariman Poushin Message-ID: <20181218152433.huenhwyajg4nhw3v@bivouac.eciton.net> References: <20181218131015.20062-1-ard.biesheuvel@linaro.org> <20181218131015.20062-4-ard.biesheuvel@linaro.org> <20181218134339.jorvyyciarq3lb3d@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 3/4] ArmPkg/GenericWatchdogDxe: clean up the code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 15:24:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 18, 2018 at 04:19:20PM +0100, Ard Biesheuvel wrote: > > > @@ -178,8 +186,8 @@ WatchdogSetTimerPeriod ( > > > > > > // if TimerPeriod is 0, this is a request to stop the watchdog. > > > if (TimerPeriod == 0) { > > > - mNumTimerTicks = 0; > > > - WatchdogDisable (); > > > + //mNumTimerTicks = 0; > > > + //WatchdogDisable (); > > > > Should these be deletions? > > > > Nope. I commented them out to test whether the watchdog actually > fires, since most shell tools (and GRUB) disable it while running in > interactive mode. > > So this whole hunk should be dropped. Works for me. / Leif