public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Shenglei Zhang <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper
Date: Wed, 19 Dec 2018 16:43:18 +0800	[thread overview]
Message-ID: <20181219084318.4024-4-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20181219084318.4024-1-shenglei.zhang@intel.com>

AsciiToUpper in EdbSupportString.c is an internal function.
And we will introduce a public function which has the same name
and effect. So we remove its implement. Code in EdbSupportString.c
now consumes the public one.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../EbcDxe/EbcDebugger/EdbSupportString.c         | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
index 78a0559079..0eb894ddfb 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
@@ -323,21 +323,6 @@ UnicodeToUpper (
   return (Chr >= L'a' && Chr <= L'z') ? Chr - (L'a' - L'A') : Chr;
 }
 
-/**
-
-  Convert the character to upper case.
-
-  @param  Chr    the character to be converted.
-
-**/
-STATIC
-CHAR8
-AsciiToUpper (
-  IN      CHAR8                     Chr
-  )
-{
-  return (Chr >= 'a' && Chr <= 'z') ? Chr - ('a' - 'A') : Chr;
-}
 
 /**
   Compare the Unicode and Ascii string pointed by String to the string pointed by String2.
-- 
2.18.0.windows.1



  parent reply	other threads:[~2018-12-19  8:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  8:43 [PATCH v3 0/3] Introduce two public functions and remove internal ones Shenglei Zhang
2018-12-19  8:43 ` [PATCH v3 1/3] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly Shenglei Zhang
2018-12-19  8:43 ` [PATCH v3 2/3] MdePkg/BaseLib: Remove InternalCharToUpper and InternalBaseLibAsciiToUpper Shenglei Zhang
2018-12-19  8:43 ` Shenglei Zhang [this message]
2018-12-19 13:06   ` [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219084318.4024-4-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox