From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26582211A1E5F for ; Wed, 19 Dec 2018 00:43:32 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 00:43:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="129087340" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga004.fm.intel.com with ESMTP; 19 Dec 2018 00:43:31 -0800 From: Shenglei Zhang To: edk2-devel@lists.01.org Cc: Jian J Wang , Hao Wu , Star Zeng Date: Wed, 19 Dec 2018 16:43:18 +0800 Message-Id: <20181219084318.4024-4-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20181219084318.4024-1-shenglei.zhang@intel.com> References: <20181219084318.4024-1-shenglei.zhang@intel.com> Subject: [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 08:43:32 -0000 AsciiToUpper in EdbSupportString.c is an internal function. And we will introduce a public function which has the same name and effect. So we remove its implement. Code in EdbSupportString.c now consumes the public one. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao Wu Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../EbcDxe/EbcDebugger/EdbSupportString.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c index 78a0559079..0eb894ddfb 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c @@ -323,21 +323,6 @@ UnicodeToUpper ( return (Chr >= L'a' && Chr <= L'z') ? Chr - (L'a' - L'A') : Chr; } -/** - - Convert the character to upper case. - - @param Chr the character to be converted. - -**/ -STATIC -CHAR8 -AsciiToUpper ( - IN CHAR8 Chr - ) -{ - return (Chr >= 'a' && Chr <= 'z') ? Chr - ('a' - 'A') : Chr; -} /** Compare the Unicode and Ascii string pointed by String to the string pointed by String2. -- 2.18.0.windows.1