public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib
Date: Wed, 19 Dec 2018 11:53:10 +0000	[thread overview]
Message-ID: <20181219115310.lqkh55iwcs6w4lkb@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu8n=4C4Dbt1abg4QbEU1vg3NLo-TDBAbZz9m0kozLxr9Q@mail.gmail.com>

On Wed, Dec 19, 2018 at 11:08:32AM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
> > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
> > so drop them.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as c718cc0378.

> > ---
> >  Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > index 23c5e563bb..3fbc0548aa 100644
> > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > @@ -52,8 +52,6 @@ [Pcd]
> >  [FixedPcd]
> >    gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable
> >    gArmPlatformTokenSpaceGuid.PcdCoreCount
> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
> >    gAmdStyxTokenSpaceGuid.PcdEnableKcs
> >    gAmdStyxTokenSpaceGuid.PcdSata1PortCount
> >
> > --
> > 2.11.0
> >


      reply	other threads:[~2018-12-19 11:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 18:38 [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib Leif Lindholm
2018-12-19 10:08 ` Ard Biesheuvel
2018-12-19 11:53   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219115310.lqkh55iwcs6w4lkb@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox