From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F1AB211A1E4D for ; Wed, 19 Dec 2018 03:53:14 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id x10so19206397wrs.8 for ; Wed, 19 Dec 2018 03:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kJ7ZMLO7MfymmWdOBuqcjWBS9o/rafVPozSv5HsBDAQ=; b=ElciJlSuM88bdtZbQi9Zed9WaqakX3hFSSbeK9tkLEAFGC8YA+RAeof1Dj3FToxSeP IFFGH7y++Jjk0LKxD7GrpG83b9xOXdRBc11x0rd0ZFlivB2frqjszRXmZ7zjEAnqPSnT R3uk/PgoREa7Tz2PLsaQsriQ4p7n+PQXWFBX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kJ7ZMLO7MfymmWdOBuqcjWBS9o/rafVPozSv5HsBDAQ=; b=kY9SubD0h3LZRkuPcFWawu/gYqOwkIV2aYmnrbQLfdqLe4axCvpwKp4QfC3fis2qO/ lOLVt9ueHIbKGoydCyEnsi7GjGaWcPDZhgK5f18Gg+lIiecm9TK9by/WpqOEnaE7/JyY av1MCO28fxIzWQyTZLtsJmcRGd6zXdmzIUxtT2DCfTmGL9iFle6r/M0/xrkiisvWWByP +NNcwCLPAcToqbq88QOJtRNINe37UbvsqScnev8KOrtnWqMmwPHelEVeuoWZzb0UGvfF jv5CmwldZySkyIIcGUzy1irjK0RkR+9RyRV9bYUgB/047nmbAafjXXtJCwqQ7yniHzSG yX5g== X-Gm-Message-State: AA+aEWZRt9/Uyy97Mkay1NtpFm0vT+HcgLnU3b5CXrdICqDwVpR9umkl sPgKVm3fwwCMEYV1C/r8JshYvQ== X-Google-Smtp-Source: AFSGD/XRKQSc5EiWcZ/u6TMqtLhec2XI4oKZrel0uczQpNLYg5CarWk1A0BJWMdnNOw7tM5HzU4a+w== X-Received: by 2002:adf:8421:: with SMTP id 30mr19054763wrf.153.1545220392697; Wed, 19 Dec 2018 03:53:12 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a1sm6924833wrw.76.2018.12.19.03.53.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 03:53:11 -0800 (PST) Date: Wed, 19 Dec 2018 11:53:10 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20181219115310.lqkh55iwcs6w4lkb@bivouac.eciton.net> References: <20181218183832.31950-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 11:53:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 19, 2018 at 11:08:32AM +0100, Ard Biesheuvel wrote: > On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > > > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still > > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere - > > so drop them. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as c718cc0378. > > --- > > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf > > index 23c5e563bb..3fbc0548aa 100644 > > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf > > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf > > @@ -52,8 +52,6 @@ [Pcd] > > [FixedPcd] > > gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset > > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment > > gAmdStyxTokenSpaceGuid.PcdEnableKcs > > gAmdStyxTokenSpaceGuid.PcdSata1PortCount > > > > -- > > 2.11.0 > >