* [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec
@ 2018-12-18 18:38 Leif Lindholm
2018-12-19 10:08 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-12-18 18:38 UTC (permalink / raw)
To: edk2-devel
The following Pcds
- gArmTokenSpaceGuid.PcdArmLinuxSpinTable
- gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
remained defined, without actual users.
So get rid of them.
One reference to be deleted separately from edk2-platforms.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
ArmPkg/ArmPkg.dec | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index d99eb6769f..0ec5e8efd6 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -80,10 +80,6 @@ [PcdsFeatureFlag.common]
# it has been configured by the CPU DXE
gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032
- # Define if the spin-table mechanism is used by the secondary cores when booting
- # Linux (instead of PSCI)
- gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033
-
# Define if the GICv3 controller should use the GICv2 legacy
gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
@@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM]
# By default we do not do a transition to non-secure mode
gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E
- # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory
- gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020
-
- # If the fixed FDT address is not available, then it should be loaded below the kernel.
- # The recommendation from the Linux kernel is to have the FDT below 16KB.
- # (see the kernel doc: Documentation/arm/Booting)
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023
- # The FDT blob must be loaded at a 64bit aligned address.
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026
-
# Non Secure Access Control Register
# - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality
# - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31
@@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64]
# Other modes include using SP0 or switching to Aarch32, but these are
# not currently supported.
gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E
- # If the fixed FDT address is not available, then it should be loaded above the kernel.
- # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.
- # (see the kernel doc: Documentation/arm64/booting.txt)
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023
- # The FDT blob must be loaded at a 2MB aligned address.
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026
#
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec
2018-12-18 18:38 [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec Leif Lindholm
@ 2018-12-19 10:08 ` Ard Biesheuvel
2018-12-19 11:53 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-19 10:08 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> The following Pcds
> - gArmTokenSpaceGuid.PcdArmLinuxSpinTable
> - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset
> - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
> - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
> remained defined, without actual users.
> So get rid of them.
>
> One reference to be deleted separately from edk2-platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/ArmPkg.dec | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index d99eb6769f..0ec5e8efd6 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common]
> # it has been configured by the CPU DXE
> gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032
>
> - # Define if the spin-table mechanism is used by the secondary cores when booting
> - # Linux (instead of PSCI)
> - gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033
> -
> # Define if the GICv3 controller should use the GICv2 legacy
> gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
>
> @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM]
> # By default we do not do a transition to non-secure mode
> gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E
>
> - # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory
> - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020
> -
> - # If the fixed FDT address is not available, then it should be loaded below the kernel.
> - # The recommendation from the Linux kernel is to have the FDT below 16KB.
> - # (see the kernel doc: Documentation/arm/Booting)
> - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023
> - # The FDT blob must be loaded at a 64bit aligned address.
> - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026
> -
> # Non Secure Access Control Register
> # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality
> # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31
> @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64]
> # Other modes include using SP0 or switching to Aarch32, but these are
> # not currently supported.
> gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E
> - # If the fixed FDT address is not available, then it should be loaded above the kernel.
> - # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.
> - # (see the kernel doc: Documentation/arm64/booting.txt)
> - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023
> - # The FDT blob must be loaded at a 2MB aligned address.
> - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026
>
>
> #
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec
2018-12-19 10:08 ` Ard Biesheuvel
@ 2018-12-19 11:53 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2018-12-19 11:53 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Wed, Dec 19, 2018 at 11:08:48AM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > The following Pcds
> > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable
> > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
> > remained defined, without actual users.
> > So get rid of them.
> >
> > One reference to be deleted separately from edk2-platforms.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as 5f0b035f10.
> > ---
> > ArmPkg/ArmPkg.dec | 20 --------------------
> > 1 file changed, 20 deletions(-)
> >
> > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> > index d99eb6769f..0ec5e8efd6 100644
> > --- a/ArmPkg/ArmPkg.dec
> > +++ b/ArmPkg/ArmPkg.dec
> > @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common]
> > # it has been configured by the CPU DXE
> > gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032
> >
> > - # Define if the spin-table mechanism is used by the secondary cores when booting
> > - # Linux (instead of PSCI)
> > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033
> > -
> > # Define if the GICv3 controller should use the GICv2 legacy
> > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
> >
> > @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM]
> > # By default we do not do a transition to non-secure mode
> > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E
> >
> > - # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory
> > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020
> > -
> > - # If the fixed FDT address is not available, then it should be loaded below the kernel.
> > - # The recommendation from the Linux kernel is to have the FDT below 16KB.
> > - # (see the kernel doc: Documentation/arm/Booting)
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023
> > - # The FDT blob must be loaded at a 64bit aligned address.
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026
> > -
> > # Non Secure Access Control Register
> > # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality
> > # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31
> > @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64]
> > # Other modes include using SP0 or switching to Aarch32, but these are
> > # not currently supported.
> > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E
> > - # If the fixed FDT address is not available, then it should be loaded above the kernel.
> > - # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.
> > - # (see the kernel doc: Documentation/arm64/booting.txt)
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023
> > - # The FDT blob must be loaded at a 2MB aligned address.
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026
> >
> >
> > #
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-18 18:38 [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec Leif Lindholm
2018-12-19 10:08 ` Ard Biesheuvel
2018-12-19 11:53 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox