From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E85E321959CB2 for ; Wed, 19 Dec 2018 03:53:40 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id b11so5730163wmj.1 for ; Wed, 19 Dec 2018 03:53:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=D++rSVrEkHG61HjC7BtsRBFgawMDxdhpxjyGY1KYNoc=; b=MU49D2S0DKPXWcH30vlcUuQBKFzwWvq8fLLpv9CQPqweFP6EQQZvAt4b29WwB2Ry0Q J6XHy1Yr6KkiPZ/r5DQ8eQCUzxXdAiNy1YsjMiQ3c/TGJu5V1yGW11+TZnijGmmirp9t mJCuRkoT9jgEwd7ao06xMDxvqVItTmQ0m1vtA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=D++rSVrEkHG61HjC7BtsRBFgawMDxdhpxjyGY1KYNoc=; b=JfpEjBvvmAEBG/smIFQ05zcIXmHLuuflm60wKtuVU+lO3v+55qtm9u9c/DvMDIjyHa n5q+xOM6C3mOnUpNFhWuGJ9DmdAbZextHRAx3vvo/f70u8vDqTtMvjJBY+RsMaij6aod Vb90Q5ieXWpO9/0pTeVZ88wCUPAOKeOfgPUKzmxZ7pZnJVipmLwPj6ZI4Tdroa+oGWUm ksp6UaHPZ/5A0gPQubPi9FbMQl/haCs+6eYcqCKQn6B8eqlw1tLB38hquwyKwSqXuMhz fYi5onAuVzBxn6BeMr2Y66J+qr4RJN1J84KztLhtcV8I93AY4q4ewf3a+y5wt9BIY4g0 kOog== X-Gm-Message-State: AA+aEWbET5XOBKAi+hhQD7aB46FKpP5SMSX0y/rGUxPvnEWezQl4GIeW E4wu1V5l3FxOT3iqNdsn6k8aSg== X-Google-Smtp-Source: AFSGD/Xo5Kbp6rtI5tB18rdE+OHRAOIvTz+yCA0v2W8ZV7dcXUAglnfoNj5LeXpYR4lEUFakfqYI5w== X-Received: by 2002:a1c:8acf:: with SMTP id m198mr7324015wmd.143.1545220419318; Wed, 19 Dec 2018 03:53:39 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 10sm4861185wmy.40.2018.12.19.03.53.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 03:53:38 -0800 (PST) Date: Wed, 19 Dec 2018 11:53:37 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20181219115337.pzzz2giwqtwcyxlo@bivouac.eciton.net> References: <20181218183846.31999-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 11:53:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 19, 2018 at 11:08:48AM +0100, Ard Biesheuvel wrote: > On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > > > The following Pcds > > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable > > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset > > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset > > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment > > remained defined, without actual users. > > So get rid of them. > > > > One reference to be deleted separately from edk2-platforms. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as 5f0b035f10. > > --- > > ArmPkg/ArmPkg.dec | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > > index d99eb6769f..0ec5e8efd6 100644 > > --- a/ArmPkg/ArmPkg.dec > > +++ b/ArmPkg/ArmPkg.dec > > @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common] > > # it has been configured by the CPU DXE > > gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032 > > > > - # Define if the spin-table mechanism is used by the secondary cores when booting > > - # Linux (instead of PSCI) > > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033 > > - > > # Define if the GICv3 controller should use the GICv2 legacy > > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 > > > > @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM] > > # By default we do not do a transition to non-secure mode > > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E > > > > - # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory > > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020 > > - > > - # If the fixed FDT address is not available, then it should be loaded below the kernel. > > - # The recommendation from the Linux kernel is to have the FDT below 16KB. > > - # (see the kernel doc: Documentation/arm/Booting) > > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023 > > - # The FDT blob must be loaded at a 64bit aligned address. > > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026 > > - > > # Non Secure Access Control Register > > # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality > > # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31 > > @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64] > > # Other modes include using SP0 or switching to Aarch32, but these are > > # not currently supported. > > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E > > - # If the fixed FDT address is not available, then it should be loaded above the kernel. > > - # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB. > > - # (see the kernel doc: Documentation/arm64/booting.txt) > > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023 > > - # The FDT blob must be loaded at a 2MB aligned address. > > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026 > > > > > > # > > -- > > 2.11.0 > >