Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Dec 12, 2018 at 03:17:29PM +0000, Leif Lindholm wrote:
> > Considering the commit log from its introduction
> > 
> > """
> > commit 969eba7b0df70c9aa261eaf005085568b88de87c
> > Author: andrewfish <andrewfish@6f19259b-4bc3-4df7-8a09-765794883524>
> > Date:   Sat Apr 3 00:41:42 2010 +0000
> > 
> > Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have
> > low level interrupt code yet. I've been testing on ARM.
> > 
> > git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334
> > 6f19259b-4bc3-4df7-8a09-765794883524
> > """
> > 
> > the lack of low level interrupt code in this patch, and the following
> > snippet from the .inf
> > 
> > """
> > [Sources.X64]
> >   Ia32/Processor.c
> > 
> > [Sources.Ia32]
> >   X64/Processor.c
> > """
> > 
> > I think it is safe to say that this code was never used on anything but ARM.
> 
> I believe the same, but since we have the author of both the code and
> that commit message easily accessible, I would like to verify before
> we nuke it.

Well, he didn't speak up for a week, and is probably riding
wilderbeest as I type this - so yeah, go ahead.

We can always revert :)

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

/
    Leif