From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F33082119FF4D for ; Wed, 19 Dec 2018 07:20:29 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id u4so18934272wrp.3 for ; Wed, 19 Dec 2018 07:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IQFEO7a/QyztkSywjFwEItCATwAtbUkWv/rpPeJN/HE=; b=Ask8sCtPPN95qJLl5us8G5Fi/lmdSxB7C1AZS/su6FO3gDzwL0xewyzqloefykmB+D H+Ou8cI1SvIA0qt9Wz5uh67TdQ/HyeJmE0dHxpiKyl2Vnvdc3/dGVkCmXrQEfljEj/iJ TK/AbW6Y7v+orm96brJnYXGhThT2lHjkDWOe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IQFEO7a/QyztkSywjFwEItCATwAtbUkWv/rpPeJN/HE=; b=jYh5qmWO9r5I5+TD7wzYyint29vRPQxr2QN4zf3eLoFAxAMLwLqDO+DohG+O49TV9P l8fYBbffs2h32MlDvpYZGaRabJn3MY/mY6CKxr7lN0H/GkESUl5j86Gn2VUHLHn0DY2C 02nz6DmeOnun+rdfUmCvG0gycGToanctGZ5lQfevUeaOGQvenc19vBHaWOdIAXor4JjN 49rnkzarLLEFPeaDZGGwlTn8IQGGJIcAkqNoRPWNgVwj7NoKqNrYa7xsPaoBMMKeqQzq pGPyPENYt0Ho3+BsOBjKKp4Gt7Y+Z0RYJp0usB08Yb2emmXbFSCiHWkrhy5N/REyV6Oi oiQw== X-Gm-Message-State: AA+aEWZTxB/qiO8NukPh02B/Mqox8cWapwPiaSZGdsUP/kGVufpK/tyU zp9U0PPMpdKcRtJ46yX2CZU3Kg== X-Google-Smtp-Source: AFSGD/Wei8BZOiy505dkoSJw0uxbtFPutRru+EMb9WpjRVr/BwngkhqLyhWiTryeFiUH1C6iEG0XdA== X-Received: by 2002:adf:a452:: with SMTP id e18mr11369705wra.190.1545232828296; Wed, 19 Dec 2018 07:20:28 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s3sm3537507wmj.23.2018.12.19.07.20.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 07:20:27 -0800 (PST) Date: Wed, 19 Dec 2018 15:20:26 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Andrew Fish Message-ID: <20181219152026.z37y3oa5thzd2fp6@bivouac.eciton.net> References: <20181212124842.15968-1-ard.biesheuvel@linaro.org> <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net> <20181212151729.cdqz6fmw6a4ez5hh@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20181212151729.cdqz6fmw6a4ez5hh@bivouac.eciton.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 15:20:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 12, 2018 at 03:17:29PM +0000, Leif Lindholm wrote: > > Considering the commit log from its introduction > > > > """ > > commit 969eba7b0df70c9aa261eaf005085568b88de87c > > Author: andrewfish > > Date: Sat Apr 3 00:41:42 2010 +0000 > > > > Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have > > low level interrupt code yet. I've been testing on ARM. > > > > git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334 > > 6f19259b-4bc3-4df7-8a09-765794883524 > > """ > > > > the lack of low level interrupt code in this patch, and the following > > snippet from the .inf > > > > """ > > [Sources.X64] > > Ia32/Processor.c > > > > [Sources.Ia32] > > X64/Processor.c > > """ > > > > I think it is safe to say that this code was never used on anything but ARM. > > I believe the same, but since we have the author of both the code and > that commit message easily accessible, I would like to verify before > we nuke it. Well, he didn't speak up for a week, and is probably riding wilderbeest as I type this - so yeah, go ahead. We can always revert :) Reviewed-by: Leif Lindholm / Leif