From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E8EDE2119FF42 for ; Wed, 19 Dec 2018 08:56:56 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id b11so6720337wmj.1 for ; Wed, 19 Dec 2018 08:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+8O9u90+iEDnqpk/K1z4lD5g09nA0WdLpwvQzwQs1e0=; b=IRQ6wFy+1DFb5wfhWbnqiBmdnXxGWEbKn+DPIMjbK1qspF/SRRnmfkVGWzjCPNBdAb C/pLmsNWWRQ2/Wa5iLtoxqZHmj2HWO3j58kSIoeMrzApbSwcuAyjGnQixjk38ucWs8sF v1x57+8KMNiljqWm83WX2MCuFa+SpqqGnFPW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+8O9u90+iEDnqpk/K1z4lD5g09nA0WdLpwvQzwQs1e0=; b=Shk66bPQDR8C34DVHKnyA/boKiMD5oUwib1KdtotNaT1U+GQ4A7zs+xd++rdfcQBwB 655Cw/P5qCwWVSGBB7WQRkw6dVhDYPfnaVzPgPFeiE2gsWILhxIXFP8uvIQP+FT3+0ua RVEl638CiVja0MApXMUROQ/Gh7YlLRXk4WySjp5z8wGQJsRxt+M0iE+bhdSLg4m2e1F5 I0vf9az/mU1tCkg7juYDA9xct2OehnylDB3cJKD87fI3KeUQOGC3DYIGr3y+R73hiaia igHmIuJoWCOr0IbM2W5pgrPlS4iCgKdJ9jUBWJJHU7g8LN+nUBaUs5NCc51jChMZjk6t EhVw== X-Gm-Message-State: AA+aEWatsNZS9OC/wVZfQDwbE1CMDux+PPW+7B1MBJ13XNjgMAU2ExOF zydsbOK39feNE9rwWxmQdnVAng== X-Google-Smtp-Source: AFSGD/WD1PthkboNXwfw8WtN624LYUqqd6aP+ctF5e93TiRPSboNdyfa4DIhXDrIyGGgAzZIRLKgIA== X-Received: by 2002:a1c:b687:: with SMTP id g129mr7820623wmf.59.1545238614613; Wed, 19 Dec 2018 08:56:54 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d4sm7601364wrp.89.2018.12.19.08.56.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 08:56:53 -0800 (PST) Date: Wed, 19 Dec 2018 16:56:52 +0000 From: Leif Lindholm To: Fu Siyuan Cc: edk2-devel@lists.01.org Message-ID: <20181219165652.l5gkr43fq5hcnjpr@bivouac.eciton.net> References: <20181219054206.13316-1-siyuan.fu@intel.com> MIME-Version: 1.0 In-Reply-To: <20181219054206.13316-1-siyuan.fu@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/2] Delete TCP, PXE, iSCSI driver in MdeModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 16:56:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 19, 2018 at 01:42:03PM +0800, Fu Siyuan wrote: > This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe > drivers in MdeModulePkg. These drivers will not be maintained and can't > co-work with the dual-stack drivers in NetworkPkg. > > In future, people should use below NetworkPkg drivers instead: > NetworkPkg/IScsiDxe/IScsiDxe.inf > NetworkPkg/TcpDxe/TcpDxe.inf > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > These drivers are actively maintained with more bug fixes and new feature > support. > > All edk2 platforms DSC/FDF have already been updated to use the NetworkPkg > drivers in privious patch. > > Bugzilla link: https://bugzilla.tianocore.org/show_bug.cgi?id=1278 I have no issue with this - as long as it happens soon. This is a very invasive change, and I want a long time between this removal and the next stable tag. However, due to the amount of code involved (and the impact this has on email servers), but also to allow more flexibility if we _do_ end up having to revert, it would be useful if this was split up into one patch per deleted module. / Leif > Fu Siyuan (2): > MdeModulePkg: Delete the TCP/PXE/ISCSI drivers in MdeModulePkg. > NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF. > > .../Network/IScsiDxe/ComponentName.c | 283 -- > .../Universal/Network/IScsiDxe/IScsiCHAP.c | 430 --- > .../Universal/Network/IScsiDxe/IScsiConfig.c | 1264 ------- > .../Universal/Network/IScsiDxe/IScsiDhcp.c | 472 --- > .../Universal/Network/IScsiDxe/IScsiDriver.c | 676 ---- > .../Network/IScsiDxe/IScsiExtScsiPassThru.c | 412 --- > .../Universal/Network/IScsiDxe/IScsiIbft.c | 539 --- > .../Network/IScsiDxe/IScsiInitiatorName.c | 116 - > .../Universal/Network/IScsiDxe/IScsiMisc.c | 948 ------ > .../Universal/Network/IScsiDxe/IScsiProto.c | 2799 --------------- > .../Universal/Network/IScsiDxe/IScsiTcp4Io.c | 487 --- > MdeModulePkg/Universal/Network/IScsiDxe/Md5.c | 350 -- > .../Universal/Network/Tcp4Dxe/ComponentName.c | 433 --- > .../Universal/Network/Tcp4Dxe/SockImpl.c | 1201 ------- > .../Universal/Network/Tcp4Dxe/SockInterface.c | 990 ------ > .../Network/Tcp4Dxe/Tcp4Dispatcher.c | 717 ---- > .../Universal/Network/Tcp4Dxe/Tcp4Driver.c | 782 ----- > .../Universal/Network/Tcp4Dxe/Tcp4Input.c | 1497 --------- > .../Universal/Network/Tcp4Dxe/Tcp4Io.c | 112 - > .../Universal/Network/Tcp4Dxe/Tcp4Main.c | 674 ---- > .../Universal/Network/Tcp4Dxe/Tcp4Misc.c | 940 ------ > .../Universal/Network/Tcp4Dxe/Tcp4Option.c | 352 -- > .../Universal/Network/Tcp4Dxe/Tcp4Output.c | 1238 ------- > .../Universal/Network/Tcp4Dxe/Tcp4Timer.c | 584 ---- > .../Network/UefiPxeBcDxe/ComponentName.c | 365 -- > .../Network/UefiPxeBcDxe/PxeBcDhcp.c | 1999 ----------- > .../Network/UefiPxeBcDxe/PxeBcDriver.c | 665 ---- > .../Network/UefiPxeBcDxe/PxeBcImpl.c | 2989 ----------------- > .../Network/UefiPxeBcDxe/PxeBcMtftp.c | 454 --- > .../Network/UefiPxeBcDxe/PxeBcSupport.c | 221 -- > MdeModulePkg/MdeModulePkg.dsc | 3 - > .../Network/IScsiDxe/ComponentName.h | 165 - > .../Universal/Network/IScsiDxe/IScsi4Dxe.uni | 25 - > .../Network/IScsiDxe/IScsi4DxeExtra.uni | 20 - > .../Universal/Network/IScsiDxe/IScsiCHAP.h | 106 - > .../Universal/Network/IScsiDxe/IScsiCommon.h | 22 - > .../Universal/Network/IScsiDxe/IScsiConfig.h | 166 - > .../Network/IScsiDxe/IScsiConfigDxe.vfr | 219 -- > .../IScsiDxe/IScsiConfigDxeStrings.uni | 62 - > .../Network/IScsiDxe/IScsiConfigNVDataStruc.h | 109 - > .../Universal/Network/IScsiDxe/IScsiDhcp.h | 55 - > .../Universal/Network/IScsiDxe/IScsiDriver.h | 140 - > .../Universal/Network/IScsiDxe/IScsiDxe.inf | 134 - > .../Network/IScsiDxe/IScsiExtScsiPassThru.h | 22 - > .../Universal/Network/IScsiDxe/IScsiIbft.h | 38 - > .../Universal/Network/IScsiDxe/IScsiImpl.h | 168 - > .../Network/IScsiDxe/IScsiInitiatorName.h | 74 - > .../Universal/Network/IScsiDxe/IScsiMisc.h | 317 -- > .../Universal/Network/IScsiDxe/IScsiProto.h | 1005 ------ > .../Universal/Network/IScsiDxe/IScsiTcp4Io.h | 142 - > MdeModulePkg/Universal/Network/IScsiDxe/Md5.h | 80 - > .../Universal/Network/Tcp4Dxe/SockImpl.h | 131 - > .../Universal/Network/Tcp4Dxe/Socket.h | 954 ------ > .../Universal/Network/Tcp4Dxe/Tcp4Driver.h | 342 -- > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 94 - > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.uni | 23 - > .../Network/Tcp4Dxe/Tcp4DxeExtra.uni | 20 - > .../Universal/Network/Tcp4Dxe/Tcp4Func.h | 781 ----- > .../Universal/Network/Tcp4Dxe/Tcp4Main.h | 494 --- > .../Universal/Network/Tcp4Dxe/Tcp4Option.h | 130 - > .../Universal/Network/Tcp4Dxe/Tcp4Proto.h | 357 -- > .../Network/UefiPxeBcDxe/PxeBcDhcp.h | 502 --- > .../Network/UefiPxeBcDxe/PxeBcDriver.h | 102 - > .../Network/UefiPxeBcDxe/PxeBcImpl.h | 189 -- > .../Network/UefiPxeBcDxe/PxeBcMtftp.h | 137 - > .../Network/UefiPxeBcDxe/PxeBcSupport.h | 134 - > .../Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni | 25 - > .../UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni | 20 - > .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 102 - > NetworkPkg/IScsiDxe/IScsiDxe.inf | 10 - > NetworkPkg/TcpDxe/TcpDxe.inf | 6 - > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 6 - > 72 files changed, 32620 deletions(-) > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dispatcher.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/ComponentName.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsi4Dxe.uni > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsi4DxeExtra.uni > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCommon.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxe.vfr > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxeStrings.uni > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigNVDataStruc.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.uni > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4DxeExtra.uni > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Proto.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni > delete mode 100644 MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > -- > 2.19.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel