From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD3302194D3B9 for ; Wed, 19 Dec 2018 10:33:51 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p6so7204680wmc.1 for ; Wed, 19 Dec 2018 10:33:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2TQsea+A+fZ13qnJbxKiHwf6M0D108kR8IeWPMWtm+E=; b=kHXALKDRU6ZdQ8TRrVk0tw3foOGPaMVMrljxEY3P93ZruqEEvtLwtOEC8Uqx5Swvmd 1DSzZ/8z9RgB7MvlOLCuB6lxOdCHTHy9kzlzVsLqVR/WGnayF8a9iuvReroa51fCp3H+ UewPr4VgpzS/YgPt8l5QKl1XvvF2Ks1h18360= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2TQsea+A+fZ13qnJbxKiHwf6M0D108kR8IeWPMWtm+E=; b=QAJ8NPY9i7nROetqcpBawmipyekbAaPz5drxlM5JKee2TQTMcMURVFkppdiSKVVfwi YaC0IcS9bCnH3xt5x0gxD0f0V/wYOeGZS7a5I7WJSwYGMeLoZYCUE/hFI0cgEiGymdB0 0HnEiqII6Q9P2tv3ydKj8xdGqi/InNlilY5bgaA0FeGgzhiJU+sVMIcak857AElnokCl PDglQS97J7NcKAyeLcoJNbqIPFHy0SJa8QFlRZL9NN6EShO/EDGVW9kW7vV5mlHDgosF NE+G5+AurHIU/MewWDdpggswT6JzrjqJmnHe31LGXRGet+CqPJHOZBF9GV7b3lVkN1SV e4nQ== X-Gm-Message-State: AA+aEWYkGGomC5NxSZXlvAtjCRjnUmApyAvYRYVPIHn/2un4VwTz9czw IpMdDGksupJCUgxuYj2Y06omwQ== X-Google-Smtp-Source: AFSGD/WLnY9PvdcknxytGnaObtPE8dKWUhiyEuDBiIn1aeh1QhxFsFn9z61W5E9OwOVnvEYauTHIeQ== X-Received: by 2002:a1c:5545:: with SMTP id j66mr8375201wmb.15.1545244429965; Wed, 19 Dec 2018 10:33:49 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f18sm4383936wrs.92.2018.12.19.10.33.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 10:33:49 -0800 (PST) Date: Wed, 19 Dec 2018 18:33:47 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com Message-ID: <20181219183347.fjembpm5f6nv2ghq@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-19-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-19-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 18/41] LS1043 : Enable NOR driver for LS1043aRDB package. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 18:33:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:32PM +0530, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal I think I actually gave a Reviewed-by: Leif Lindholm for this one last round. > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 15 ++++++++++++++- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 9 ++++++++- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index 48a7b5a..9a68cfd 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -41,6 +41,7 @@ > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > BoardLib|Platform/NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Silicon/NXP/Library/FpgaLib/FpgaLib.inf > + NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > > [PcdsFixedAtBuild.common] > > @@ -65,6 +66,13 @@ > gDs1307RtcLibTokenSpaceGuid.PcdI2cSlaveAddress|0x68 > gDs1307RtcLibTokenSpaceGuid.PcdI2cBusFrequency|100000 > > + # > + # NV Storage PCDs > + # > + gArmTokenSpaceGuid.PcdVFPEnabled|1 > + gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x060000000 > + gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x60300000 > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -74,10 +82,15 @@ > # > # Architectural Protocols > # > - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > + > + NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + } > + MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > + Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > ## > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > index 417303d..6b27aed 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > @@ -55,6 +55,7 @@ gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > FV = FVMAIN_COMPACT > > !include Platform/NXP/FVRules.fdf.inc > +!include VarStore.fdf.inc > ################################################################################ > # > # FV Section > @@ -104,7 +105,8 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > INF EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > - INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > > INF Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > @@ -124,6 +126,11 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > # > + # NOR Driver > + # > + INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > -- > 1.9.1 >