From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5028D2119BBF7 for ; Wed, 19 Dec 2018 10:54:30 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id y139so7061493wmc.5 for ; Wed, 19 Dec 2018 10:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hXrA/VUsvCyIwD70NFMZcepS2RWaAYfDoNHAooo2UPk=; b=kGywsJfcYwzif3N5nTpS01CMucyMoZzdY1yoU/nVw8rRmlwAFC2Q/etjBX0BMUikvH 0dqu5ypiU7WI+Y4J/3ETAdi1UKfDgjPXAj5nREVV9WhKSo6VlFktgO8XUC533R0ErUKY S71RsiOMnYUQcyaz814JbZTygl5X30owuoTW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hXrA/VUsvCyIwD70NFMZcepS2RWaAYfDoNHAooo2UPk=; b=e+eIDHYmTSSnnOEO4dTcMZsO9bjj5Q52D4A4UbjqZQFXpPfeiKH/xqWHPbml5XGCu8 XQU3BfsTs6/47K2Ni7TvOit/2pv+vcZ0FU+NPJsyHC1vxhbN58GMUjAW53wvrFYgL5mb pbehbyLEiDOm0HMfe/aI9zG5y2l+PF8T3KWlr4e466g6D7PmnhVddEEebt39EPt9uJJN 7n35Zz4IbH/QbTAFDIwcDiLJTcrGEATYrcVWjIa/ovtFt8nc+KYo/OSqbeRqZiVM9v/w VEycgFXlVtzTuajCu7DletySoclvSK+Kl3lJK9hnTMCkFR3yB0eV5qYKswuJ/timv1MX p95Q== X-Gm-Message-State: AA+aEWZd+E4x8AIA/kw9g+FiDpDDoNMC2Eb4D1TUtleMkub8A3YNprJg Uu9EZApjscIHmlFxG34j24/ZGQ== X-Google-Smtp-Source: AFSGD/Uqh9Wt0tKPHXzqu5wU+COC/dEVoIfI/3TFVBV6yMVoNH83WcW6AM2GhS3ZPvgIGwm+KdQjng== X-Received: by 2002:a1c:f319:: with SMTP id q25mr8289516wmq.151.1545245668723; Wed, 19 Dec 2018 10:54:28 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f2sm4914853wre.34.2018.12.19.10.54.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 10:54:27 -0800 (PST) Date: Wed, 19 Dec 2018 18:54:26 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20181219185426.flf2e2eezhdjog2c@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-22-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-22-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 21/41] Platform/NXP: LS1046A RDB Board Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 18:54:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:35PM +0530, Meenakshi Aggarwal wrote: > Library to provide board specific timings for LS1046ARDB > board with interfacing to IFC controller for accessing > FPGA and NAND. Expand IFC in commit message, please. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Reviewed-by: Leif Lindholm > --- > .../NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h | 83 ++++++++++++++++++++++ > .../NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.c | 61 ++++++++++++++++ > .../LS1046aRdbPkg/Library/BoardLib/BoardLib.inf | 31 ++++++++ > 3 files changed, 175 insertions(+) > create mode 100644 Platform/NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h > create mode 100644 Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.c > create mode 100644 Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf > > diff --git a/Platform/NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h b/Platform/NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h > new file mode 100644 > index 0000000..e15100d > --- /dev/null > +++ b/Platform/NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h > @@ -0,0 +1,83 @@ > +/** IfcBoardSpecificLib.h > + > + IFC Flash Board Specific Macros and structure > + > + Copyright 2017 NXP > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD License > + which accompanies this distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > +#ifndef __IFC__BOARD_SPECIFIC_H__ > +#define __IFC__BOARD_SPECIFIC_H__ NXP_ and/or QORIQ_ prefix on include guards? > + > +#include > + > +// On board flash support > +#define IFC_NAND_BUF_BASE 0x7E800000 > + > +// On board Inegrated flash Controller chip select configuration > +#define IFC_NOR_CS IFC_CS_MAX > +#define IFC_NAND_CS IFC_CS0 > +#define IFC_FPGA_CS IFC_CS2 > + > +// board-specific NAND timing > +#define NAND_FTIM0 (IFC_FTIM0_NAND_TCCST(0x7) | \ > + IFC_FTIM0_NAND_TWP(0x18) | \ > + IFC_FTIM0_NAND_TWCHT(0x7) | \ > + IFC_FTIM0_NAND_TWH(0xa)) > + > +#define NAND_FTIM1 (IFC_FTIM1_NAND_TADLE(0x32) | \ > + IFC_FTIM1_NAND_TWBE(0x39) | \ > + IFC_FTIM1_NAND_TRR(0xe) | \ > + IFC_FTIM1_NAND_TRP(0x18)) > + > +#define NAND_FTIM2 (IFC_FTIM2_NAND_TRAD(0xf) | \ > + IFC_FTIM2_NAND_TREH(0xa) | \ > + IFC_FTIM2_NAND_TWHRE(0x1e)) > + > +#define NAND_FTIM3 0x0 > + > +#define NAND_CSPR (IFC_CSPR_PHYS_ADDR(IFC_NAND_BUF_BASE) \ > + | IFC_CSPR_PORT_SIZE_8 \ > + | IFC_CSPR_MSEL_NAND \ > + | IFC_CSPR_V) > + > +#define NAND_CSPR_EXT 0x0 > +#define NAND_AMASK 0xFFFF0000 > + > +#define NAND_CSOR (IFC_CSOR_NAND_ECC_ENC_EN /* ECC on encode */ \ > + | IFC_CSOR_NAND_ECC_DEC_EN /* ECC on decode */ \ > + | IFC_CSOR_NAND_ECC_MODE_8 /* 8-bit ECC */ \ > + | IFC_CSOR_NAND_RAL_3 /* RAL = 3 Bytes */ \ > + | IFC_CSOR_NAND_PGS_4K /* Page Size = 4K */ \ > + | IFC_CSOR_NAND_SPRZ_224 /* Spare size = 224 */ \ > + | IFC_CSOR_NAND_PB(6)) /* 2^6 Pages Per Block */ > + > +// board-specific fpga timing > +#define FPGA_BASE_PHYS 0x7fb00000 > +#define FPGA_CSPR_EXT 0x0 > +#define FPGA_CSPR (IFC_CSPR_PHYS_ADDR(FPGA_BASE_PHYS) | \ > + IFC_CSPR_PORT_SIZE_8 | \ > + IFC_CSPR_MSEL_GPCM | \ > + IFC_CSPR_V) > + > +#define FPGA_AMASK IFC_AMASK(64 * 1024) > +#define FPGA_CSOR IFC_CSOR_NOR_ADM_SHIFT(16) > + > +#define FPGA_FTIM0 (IFC_FTIM0_GPCM_TACSE(0x0e) | \ > + IFC_FTIM0_GPCM_TEADC(0x0e) | \ > + IFC_FTIM0_GPCM_TEAHC(0x0e)) > +#define FPGA_FTIM1 (IFC_FTIM1_GPCM_TACO(0xff) | \ > + IFC_FTIM1_GPCM_TRAD(0x3f)) > +#define FPGA_FTIM2 (IFC_FTIM2_GPCM_TCS(0xf) | \ > + IFC_FTIM2_GPCM_TCH(0xf) | \ > + IFC_FTIM2_GPCM_TWP(0x3E)) > +#define FPGA_FTIM3 0x0 > + > +#endif //__IFC__BOARD_SPECIFIC_H__ > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.c b/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.c > new file mode 100644 > index 0000000..0971935 > --- /dev/null > +++ b/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.c > @@ -0,0 +1,61 @@ > +/** @file > + > + Copyright 2018 NXP > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD License > + which accompanies this distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#include > + > +VOID > +GetIfcNorFlashTimings ( > + IN IFC_TIMINGS * NorIfcTimings > + ) > +{ > + NorIfcTimings->CS = IFC_NOR_CS; > + > + return ; Drop space before ; / Leif > +} > + > +VOID > +GetIfcFpgaTimings ( > + IN IFC_TIMINGS *FpgaIfcTimings > + ) > +{ > + FpgaIfcTimings->Ftim[0] = FPGA_FTIM0; > + FpgaIfcTimings->Ftim[1] = FPGA_FTIM1; > + FpgaIfcTimings->Ftim[2] = FPGA_FTIM2; > + FpgaIfcTimings->Ftim[3] = FPGA_FTIM3; > + FpgaIfcTimings->Cspr = FPGA_CSPR; > + FpgaIfcTimings->CsprExt = FPGA_CSPR_EXT; > + FpgaIfcTimings->Amask = FPGA_AMASK; > + FpgaIfcTimings->Csor = FPGA_CSOR; > + FpgaIfcTimings->CS = IFC_FPGA_CS; > + > + return; > +} > + > +VOID > +GetIfcNandFlashTimings ( > + IN IFC_TIMINGS * NandIfcTimings > + ) > +{ > + NandIfcTimings->Ftim[0] = NAND_FTIM0; > + NandIfcTimings->Ftim[1] = NAND_FTIM1; > + NandIfcTimings->Ftim[2] = NAND_FTIM2; > + NandIfcTimings->Ftim[3] = NAND_FTIM3; > + NandIfcTimings->Cspr = NAND_CSPR; > + NandIfcTimings->CsprExt = NAND_CSPR_EXT; > + NandIfcTimings->Amask = NAND_AMASK; > + NandIfcTimings->Csor = NAND_CSOR; > + NandIfcTimings->CS = IFC_NAND_CS; > + > + return; > +} > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf b/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf > new file mode 100644 > index 0000000..151c383 > --- /dev/null > +++ b/Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf > @@ -0,0 +1,31 @@ > +# @file > +# > +# Copyright 2018 NXP > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = BoardLib > + FILE_GUID = 66041dab-97b4-4b45-b9b4-1209a2d55d7a > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = BoardLib > + > +[Sources.common] > + BoardLib.c > + > +[Packages] > + MdePkg/MdePkg.dec > + Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dec > + Silicon/NXP/NxpQoriqLs.dec > + > +[FixedPcd] > + gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1BaseAddr > -- > 1.9.1 >