From: Eric Dong <eric.dong@intel.com>
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless function.
Date: Thu, 20 Dec 2018 09:15:53 +0800 [thread overview]
Message-ID: <20181220011553.14900-4-eric.dong@intel.com> (raw)
In-Reply-To: <20181220011553.14900-1-eric.dong@intel.com>
Directly call the API instead of create function for it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1411
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
.../PeiRegisterCpuFeaturesLib.c | 35 +++++-----------------
1 file changed, 8 insertions(+), 27 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index 0bbcb50181..fdd0791c89 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -67,32 +67,6 @@ GetCpuFeaturesData (
return CpuInitData;
}
-/**
- Worker function to get MP PPI service pointer.
-
- @return PEI PPI service pointer.
-**/
-EFI_PEI_MP_SERVICES_PPI *
-GetMpPpi (
- VOID
- )
-{
- EFI_STATUS Status;
- EFI_PEI_MP_SERVICES_PPI *CpuMpPpi;
-
- //
- // Get MP Services Protocol
- //
- Status = PeiServicesLocatePpi (
- &gEfiPeiMpServicesPpiGuid,
- 0,
- NULL,
- (VOID **)&CpuMpPpi
- );
- ASSERT_EFI_ERROR (Status);
- return CpuMpPpi;
-}
-
/**
Worker function to return processor index.
@@ -139,7 +113,14 @@ GetProcessorInformation (
EFI_PEI_MP_SERVICES_PPI *CpuMpPpi;
EFI_STATUS Status;
- CpuMpPpi = GetMpPpi ();
+ Status = PeiServicesLocatePpi (
+ &gEfiPeiMpServicesPpiGuid,
+ 0,
+ NULL,
+ (VOID **)&CpuMpPpi
+ );
+ ASSERT_EFI_ERROR (Status);
+
Status = CpuMpPpi->GetProcessorInfo (
GetPeiServicesTablePointer(),
CpuMpPpi,
--
2.15.0.windows.1
next prev parent reply other threads:[~2018-12-20 1:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 1:15 [Patch 0/3] Avoid AP calls PeiService Eric Dong
2018-12-20 1:15 ` [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: " Eric Dong
2018-12-20 1:19 ` Yao, Jiewen
2018-12-20 1:22 ` Dong, Eric
2018-12-20 2:06 ` Ni, Ruiyu
2018-12-20 2:08 ` Yao, Jiewen
2018-12-20 16:36 ` Brian J. Johnson
2018-12-21 2:06 ` Dong, Eric
2019-01-09 5:26 ` Dong, Eric
2019-01-09 10:35 ` Laszlo Ersek
2019-01-10 5:53 ` Dong, Eric
[not found] ` <734D49CCEBEEF84792F5B80ED585239D5BFAE3BF@SHSMSX103.ccr.corp.intel.com>
2019-01-10 12:51 ` Laszlo Ersek
2018-12-20 1:15 ` [Patch 2/3] " Eric Dong
2018-12-20 1:15 ` Eric Dong [this message]
2018-12-20 2:03 ` [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless function Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220011553.14900-4-eric.dong@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox