Re: [PATCH edk2-platforms v2 3/3] Platform/ARM/SgiPkg: Enable MmCommunication module on the platform

[Sughosh Ganu <sughosh.ganu@arm.com>]

On Thu Dec 20, 2018 at 09:52:46AM +0100, Ard Biesheuvel wrote:
> On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu <sughosh.ganu@arm.com> wrote:
> >
> > The ArmMmCommunication module is used for communication between
> > non-secure and secure world using Arm's Management Mode
> > Specification. Enable this module on Sgi platforms. This would be used
> > subsequently by the RAS and SecureBoot features, support for which
> > is to be added on the platform.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > ---
> >  Platform/ARM/SgiPkg/SgiPlatform.dsc | 18 ++++++++++++++++++
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf |  5 +++++
> >  2 files changed, 23 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > index 7995c7d132d6..948b75631a00 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > @@ -197,6 +197,20 @@ [PcdsFixedAtBuild.common]
> >    gArmSgiTokenSpaceGuid.PcdVirtioNetSize|0x10000
> >    gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt|204
> >
> > +!if $(ARM_STANDALONE_MM_ENABLE) == TRUE
> 
> Why is this inclusion conditional (here and below)? I was under the
> impression that the communicate driver fails gracefully if the secure
> standalone MM is absent. If this is not the case, please propose how
> to fix the core driver so that it does.


I have tried it earlier, and it does fail gracefully -- will test it
once more nonetheless before posting an updated version.

-sughosh