From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sughosh.ganu@arm.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=217.140.101.70; helo=foss.arm.com;
 envelope-from=sughosh.ganu@arm.com; receiver=edk2-devel@lists.01.org 
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id B4A7D211A2DBE
 for <edk2-devel@lists.01.org>; Thu, 20 Dec 2018 02:09:48 -0800 (PST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C5F7A78;
 Thu, 20 Dec 2018 02:09:48 -0800 (PST)
Received: from a074948-lin.blr.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.72.51.249])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CA6B3F5C0;
 Thu, 20 Dec 2018 02:09:46 -0800 (PST)
Received: by a074948-lin.blr.arm.com (sSMTP sendmail emulation);
 Thu, 20 Dec 2018 15:39:43 +0530
Date: Thu, 20 Dec 2018 15:39:43 +0530
From: Sughosh Ganu <sughosh.ganu@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Leif Lindholm <leif.lindholm@linaro.org>
Message-ID: <20181220100943.GB21368@arm.com>
References: <1545284878-21417-1-git-send-email-sughosh.ganu@arm.com>
 <1545284878-21417-4-git-send-email-sughosh.ganu@arm.com>
 <CAKv+Gu8LWqXqZkXW7FQUE68j_EoQujPGSomjWYy_6i-2KhxELQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8LWqXqZkXW7FQUE68j_EoQujPGSomjWYy_6i-2KhxELQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH edk2-platforms v2 3/3] Platform/ARM/SgiPkg: Enable MmCommunication module on the platform
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 10:09:49 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu Dec 20, 2018 at 09:52:46AM +0100, Ard Biesheuvel wrote:
> On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu <sughosh.ganu@arm.com> wrote:
> >
> > The ArmMmCommunication module is used for communication between
> > non-secure and secure world using Arm's Management Mode
> > Specification. Enable this module on Sgi platforms. This would be used
> > subsequently by the RAS and SecureBoot features, support for which
> > is to be added on the platform.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > ---
> >  Platform/ARM/SgiPkg/SgiPlatform.dsc | 18 ++++++++++++++++++
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf |  5 +++++
> >  2 files changed, 23 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > index 7995c7d132d6..948b75631a00 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > @@ -197,6 +197,20 @@ [PcdsFixedAtBuild.common]
> >    gArmSgiTokenSpaceGuid.PcdVirtioNetSize|0x10000
> >    gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt|204
> >
> > +!if $(ARM_STANDALONE_MM_ENABLE) == TRUE
> 
> Why is this inclusion conditional (here and below)? I was under the
> impression that the communicate driver fails gracefully if the secure
> standalone MM is absent. If this is not the case, please propose how
> to fix the core driver so that it does.


I have tried it earlier, and it does fail gracefully -- will test it
once more nonetheless before posting an updated version.

-sughosh