From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, liming.gao@intel.com
Subject: Re: [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error
Date: Thu, 20 Dec 2018 11:21:36 +0000 [thread overview]
Message-ID: <20181220112136.g6brpo4txvqr6sbh@bivouac.eciton.net> (raw)
In-Reply-To: <20181220111201.30613-1-ard.biesheuvel@linaro.org>
On Thu, Dec 20, 2018 at 12:12:01PM +0100, Ard Biesheuvel wrote:
> Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended,
> it is #defined to itself, causing all ARM builds to break.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>
> Apologies for the breakage. Please ack asap.
>
> MdePkg/Include/Arm/ProcessorBind.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h
> index 16a61fc7a325..0b7b486125f9 100644
> --- a/MdePkg/Include/Arm/ProcessorBind.h
> +++ b/MdePkg/Include/Arm/ProcessorBind.h
> @@ -151,7 +151,7 @@ typedef INT32 INTN;
> ///
> /// Maximum usable address at boot time
> ///
> -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS
> +#define MAX_ALLOC_ADDRESS MAX_ADDRESS
>
> ///
> /// Maximum legal ARM INTN and UINTN values.
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-20 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 11:12 [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error Ard Biesheuvel
2018-12-20 11:21 ` Leif Lindholm [this message]
2018-12-20 11:30 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220112136.g6brpo4txvqr6sbh@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox