* [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error
@ 2018-12-20 11:12 Ard Biesheuvel
2018-12-20 11:21 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-20 11:12 UTC (permalink / raw)
To: edk2-devel; +Cc: liming.gao, leif.lindholm, Ard Biesheuvel
Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended,
it is #defined to itself, causing all ARM builds to break.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Apologies for the breakage. Please ack asap.
MdePkg/Include/Arm/ProcessorBind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h
index 16a61fc7a325..0b7b486125f9 100644
--- a/MdePkg/Include/Arm/ProcessorBind.h
+++ b/MdePkg/Include/Arm/ProcessorBind.h
@@ -151,7 +151,7 @@ typedef INT32 INTN;
///
/// Maximum usable address at boot time
///
-#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS
+#define MAX_ALLOC_ADDRESS MAX_ADDRESS
///
/// Maximum legal ARM INTN and UINTN values.
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error
2018-12-20 11:12 [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error Ard Biesheuvel
@ 2018-12-20 11:21 ` Leif Lindholm
2018-12-20 11:30 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-12-20 11:21 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, liming.gao
On Thu, Dec 20, 2018 at 12:12:01PM +0100, Ard Biesheuvel wrote:
> Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended,
> it is #defined to itself, causing all ARM builds to break.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>
> Apologies for the breakage. Please ack asap.
>
> MdePkg/Include/Arm/ProcessorBind.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h
> index 16a61fc7a325..0b7b486125f9 100644
> --- a/MdePkg/Include/Arm/ProcessorBind.h
> +++ b/MdePkg/Include/Arm/ProcessorBind.h
> @@ -151,7 +151,7 @@ typedef INT32 INTN;
> ///
> /// Maximum usable address at boot time
> ///
> -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS
> +#define MAX_ALLOC_ADDRESS MAX_ADDRESS
>
> ///
> /// Maximum legal ARM INTN and UINTN values.
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error
2018-12-20 11:21 ` Leif Lindholm
@ 2018-12-20 11:30 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-20 11:30 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org, Gao, Liming
On Thu, 20 Dec 2018 at 12:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Thu, Dec 20, 2018 at 12:12:01PM +0100, Ard Biesheuvel wrote:
> > Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended,
> > it is #defined to itself, causing all ARM builds to break.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed as 4a1500db2b42..87b920fe22be (with Leif's ack)
> > ---
> >
> > Apologies for the breakage. Please ack asap.
> >
> > MdePkg/Include/Arm/ProcessorBind.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h
> > index 16a61fc7a325..0b7b486125f9 100644
> > --- a/MdePkg/Include/Arm/ProcessorBind.h
> > +++ b/MdePkg/Include/Arm/ProcessorBind.h
> > @@ -151,7 +151,7 @@ typedef INT32 INTN;
> > ///
> > /// Maximum usable address at boot time
> > ///
> > -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS
> > +#define MAX_ALLOC_ADDRESS MAX_ADDRESS
> >
> > ///
> > /// Maximum legal ARM INTN and UINTN values.
> > --
> > 2.19.2
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-20 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 11:12 [PATCH] MdePkg/Arm/ProcessorBind.h: fix copy/paste error Ard Biesheuvel
2018-12-20 11:21 ` Leif Lindholm
2018-12-20 11:30 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox