From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AD42211A4584 for ; Thu, 20 Dec 2018 07:20:38 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id f188so2601399wmf.5 for ; Thu, 20 Dec 2018 07:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j4dRS80JFArwbgpclctEBXwTxvpE144vf5q1DKLBIDc=; b=JQCpvwQp1CA4CWqHYKIjsY8LGZddQrTSCqmuwUiVulILu0HThVU1bpBBbnlddt82fB OfV7T4bFEWjxFn6mwuiK9nHvCzf/82yTLVH3uc3F3VDsjuYJX7km4pqmuLkU16IxFFoY +aEqn9ebynUmKjDEN/sa5ZbAN/glxEwVSbbP0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j4dRS80JFArwbgpclctEBXwTxvpE144vf5q1DKLBIDc=; b=SVpVXUwfmdXe03VqY95spzx1ZHW1i0LhJZs+hMVonrUDojKGpjOrv2x0pSkknusIxr eyzg49gcsD+/RZq4e1Ck3eN70SrI+cMoNe9RtewfMYkGSN3/lv0K9bgoYkhlh8jKL+cw yU8dwoAfzZoxUNL/T1V9MO09v/ymzWNG+LG2v6+s/ALYZS9l4A74/YLYtfR10gd8OdYs G6T6NnGMPrVb7sRZ/FtEgM9MBjwOlHWYZE6cTJBjzsRPTtZAvxQ3MXC1xFZt9BWWNOV9 y1abMOqM9x6GWc/tCqfkDFqjw/Wbjfn3JNK11WmnP9gdD0ipiCGShx9pcjJ6IDKY6uLC hR6A== X-Gm-Message-State: AA+aEWaM7b4XDo2nybpxOUEGe9IUCU0Ra62DfZxvFIqS801GmHR6nINx YvmNgcaLQTs1CmlVcRP5tti1Gg== X-Google-Smtp-Source: AFSGD/W7y7pZUjzcYdakURJxTvdIcow79/rl1hmL5whwGKff24o9IqIq4LQmDUmOQg2i52Ki16LnCQ== X-Received: by 2002:a1c:90d5:: with SMTP id s204mr11829817wmd.148.1545319237300; Thu, 20 Dec 2018 07:20:37 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x3sm10433717wrd.19.2018.12.20.07.20.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Dec 2018 07:20:36 -0800 (PST) Date: Thu, 20 Dec 2018 15:20:35 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20181220152035.cmgkmikiaqbuxwg4@bivouac.eciton.net> References: <20181217185353.24723-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181217185353.24723-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/FVP-AArch64: use different serial ports for DEBUG and console X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 15:20:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 17, 2018 at 07:53:53PM +0100, Ard Biesheuvel wrote: > The FVP models expose several emulated serial ports, and always start with > Xterm windows connected to at least two of them. So let's switch to the > second one for DEBUG output, leaving the original one for console output > via SerialDxe. Could you clarify whether this means _all_ non-DEBUG output will go to the first UART, or whether there is a switchover point and some early non-DEBUG messages will now appear on the second UART? With that: Reviewed-by: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 7094e57ee13a..7db1c675c3d9 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -125,7 +125,7 @@ .inf diff format would have been slightly nicer here. > gArmPlatformTokenSpaceGuid.PcdSP805WatchdogClockFrequencyInHz|24000000 > > ## PL011 - Serial Terminal > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x1c090000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x1c0a0000 > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth|0 > > @@ -239,7 +239,10 @@ > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf > - MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > + MdeModulePkg/Universal/SerialDxe/SerialDxe.inf { > + > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x1c090000 > + } > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > -- > 2.17.1 >