From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17CF021959CB2 for ; Fri, 21 Dec 2018 02:23:30 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id u4so4660646wrp.3 for ; Fri, 21 Dec 2018 02:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=91DHs8EeI2BnjqiK+Ix18Gq2OTaNDddFGpotpzz4xk4=; b=LBBU40tWwCgffLeq0dxAUQY5dEw6WhELKj80PLyZA+DhwoAwPWQWb8vvzKSxvYG1BB v0w4K514DOqLEfGLALMvKIZGvYOHml5q989WU1M1qbEsz28l5YlBhMFFZdxyVavFAzFc 6bkWNsxIjSCViOvsTS5COntDn5ZtmGo7mm5Cg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=91DHs8EeI2BnjqiK+Ix18Gq2OTaNDddFGpotpzz4xk4=; b=OBQNPn1y6E2bFU3d8klyxy+K63MJDTK6DDZqzZGeXDD1p6MGd7p7JJ3G/TqlpZcEYm HF6JFGAcAm1UzWTJg5EUYlTkwoLA3kbISdEa0SF71E7hWr+FOG0ak7xqsba8h7G1EOUf 1MfrOCWULXJvwmFmEzADO4wDCILdUVH8qHDCTbRwa6RRi0cWuX+I9RxWIPSXayALwKnD OpDDHXunmL5i89OCv66ZDYRBlpBhlb2Hs5D9IPsot7EFE7xiHb8SB5xtusZkORLTRH3P Gx2ascsz6UMx6XiFRTgQ2eJh7WyQOQhg/snibUX6WdKv7UjUkvbe0RgyZ261cd4qMYms +09Q== X-Gm-Message-State: AJcUukfBkd3t+OMuwp5bU9rz1bIGfAPbJBBrd+9uqXmDusN2s4WJatx+ 1L8NICzdGUsSDH90Mp8CaR/5kw== X-Google-Smtp-Source: ALg8bN4vNXglsElw7lYPkOIURGNbTxohZHyuCibFhCM8ev4kIaMuWX6z+Hz0RY4QqVTPNWRyMWM/7Q== X-Received: by 2002:adf:fc51:: with SMTP id e17mr1906099wrs.268.1545387808564; Fri, 21 Dec 2018 02:23:28 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j63sm8287884wmb.40.2018.12.21.02.23.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 02:23:27 -0800 (PST) Date: Fri, 21 Dec 2018 10:23:26 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Wasim Khan Message-ID: <20181221102326.fyb7lmv7w4qbeydi@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-33-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-33-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 32/41] LS2088 : Enable support of FpgaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 10:23:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:46PM +0530, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > Signed-off-by: Wasim Khan > Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 3 +++ > Silicon/NXP/Include/Chassis3/Soc.h | 1 - > Silicon/NXP/LS2088A/LS2088A.dsc.inc | 1 + > Silicon/NXP/Library/SocLib/Chassis3/Soc.c | 13 ++++++++++++- > Silicon/NXP/Library/SocLib/LS2088aSocLib.inf | 2 ++ > 5 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > index 465c59e..76d51a2 100755 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > @@ -39,6 +39,9 @@ > SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds3232RtcLib/Ds3232RtcLib.inf > + IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > + BoardLib|Platform/NXP/LS2088aRdbPkg/Library/BoardLib/BoardLib.inf > + FpgaLib|Platform/NXP/LS2088aRdbPkg/Library/FpgaLib/FpgaLib.inf > > [PcdsFixedAtBuild.common] > > diff --git a/Silicon/NXP/Include/Chassis3/Soc.h b/Silicon/NXP/Include/Chassis3/Soc.h > index 8d967e7..0dd9eee 100644 > --- a/Silicon/NXP/Include/Chassis3/Soc.h > +++ b/Silicon/NXP/Include/Chassis3/Soc.h > @@ -22,7 +22,6 @@ > #define FSL_CLUSTER_CLOCKS { 1, 1, 4, 4 } /* LS208x */ > #define TP_CLUSTER_EOC_MASK 0x80000000 /* Mask for End of clusters */ > #define NUM_CC_PLLS 6 > -#define CLK_FREQ 100000000 > #define MAX_CPUS 16 > #define CHECK_CLUSTER(Cluster) ((Cluster & TP_CLUSTER_EOC_MASK) != TP_CLUSTER_EOC_MASK) > > diff --git a/Silicon/NXP/LS2088A/LS2088A.dsc.inc b/Silicon/NXP/LS2088A/LS2088A.dsc.inc > index 8f7dbb5..2cff40f 100644 > --- a/Silicon/NXP/LS2088A/LS2088A.dsc.inc > +++ b/Silicon/NXP/LS2088A/LS2088A.dsc.inc > @@ -67,5 +67,6 @@ > gNxpQoriqLsTokenSpaceGuid.PcdI2c0BaseAddr|0x02000000 > gNxpQoriqLsTokenSpaceGuid.PcdI2cSize|0x10000 > gNxpQoriqLsTokenSpaceGuid.PcdNumI2cController|4 > + gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x02240000 > > ## > diff --git a/Silicon/NXP/Library/SocLib/Chassis3/Soc.c b/Silicon/NXP/Library/SocLib/Chassis3/Soc.c > index 0fc92f4..d334bb7 100644 > --- a/Silicon/NXP/Library/SocLib/Chassis3/Soc.c > +++ b/Silicon/NXP/Library/SocLib/Chassis3/Soc.c > @@ -19,11 +19,15 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > +extern VOID PrintBoardPersonality (VOID); > +extern UINTN GetBoardSysClk (VOID); Please import these through an include file. / Leif > + > VOID > GetSysInfo ( > OUT SYS_INFO *PtrSysInfo > @@ -82,7 +86,7 @@ GetSysInfo ( > > GurBase = (VOID *)PcdGet64 (PcdGutsBaseAddr); > ClkBase = (VOID *)PcdGet64 (PcdClkBaseAddr); > - SysClk = CLK_FREQ; > + SysClk = GetBoardSysClk (); > > PtrSysInfo->FreqSystemBus = SysClk; > PtrSysInfo->FreqDdrBus = PcdGet64 (PcdDdrClk); > @@ -151,6 +155,8 @@ SocInit ( > // > SmmuInit (); > > + IfcInit (); > + > // > // Initialize the Serial Port. > // Early serial port initialization is required to print RCW, > @@ -177,4 +183,9 @@ SocInit ( > // Print Soc Personality information > // > PrintSoc (); > + > + // > + // Print Board Personality information > + // > + PrintBoardPersonality (); > } > diff --git a/Silicon/NXP/Library/SocLib/LS2088aSocLib.inf b/Silicon/NXP/Library/SocLib/LS2088aSocLib.inf > index 3d9237d..9547f5a 100644 > --- a/Silicon/NXP/Library/SocLib/LS2088aSocLib.inf > +++ b/Silicon/NXP/Library/SocLib/LS2088aSocLib.inf > @@ -29,6 +29,8 @@ > [LibraryClasses] > BaseLib > DebugLib > + FpgaLib > + IfcLib > IoAccessLib > SerialPortLib > > -- > 1.9.1 >