From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 228442119A84A for ; Fri, 21 Dec 2018 09:58:07 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id d15so6071547wmb.3 for ; Fri, 21 Dec 2018 09:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vWHtHcEDyYghEc/urK7X9J5Z9xEZNxravw5Ix/iia+U=; b=IWLgllj4Q3GaUjdVHYUftfvt0t9i0Xgx2dpx1+5O2Oe07+PENHatA9rvt3aKojTyEw YdnORYupFZwai2lhPkXWRkDZMZGkn/9UawZxIZdf15Z6+LAf0DViJQOq0dj2C1vzRyri JHxpF8mOdN7ekamx8XOL5mqmXoggv3N4/KxSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vWHtHcEDyYghEc/urK7X9J5Z9xEZNxravw5Ix/iia+U=; b=CpMeTpYA+cAAObYcfHn2c1Lam8Xa3K6BbLs62G6nj30vz9BpCZNvzIKxPb32HJhTf8 fhJ4R2y6feFb2WMHH3x06Xsvbn90ZmeqOKT8/sDJ1ASWLTgjWTNRV4QhylHSvic3o3Un 6vFjnJShD60rljJYyrLehGGwWO6RoUuzJhJu1IDQgAdPjM+7gZQQluk0zcMoIFTejbNs LyZkkQrgE9aGoj8Bhs2rMU0sWJqCXQp25f6xAJOg6An9N0GJXZTolQ/FD8XiDQSU/sbB 47YGJ3Lox4G0CpXvqhIWzhCtCtSuckioYTq9MQGa7RWD1NyT+RWgQXJXS+aE12UbY9gr zJog== X-Gm-Message-State: AA+aEWZ9S+SEMVIfpYhd51vOwx8wdmi4icBprT8ayXN1k0BWZXY8ZQjR mn7wpdU7lc8Ux/IjkGBT7i6pWFTXvKw= X-Google-Smtp-Source: AFSGD/Wm5HBRAuKtZPzJMGHnY1WqCTFSlw2Z1mR0agfpfobpuO3M7mn/DDsvS9VQeU4d9f9dqr2PdQ== X-Received: by 2002:a7b:c5cc:: with SMTP id n12mr3737366wmk.149.1545415085679; Fri, 21 Dec 2018 09:58:05 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e16sm14352695wrn.72.2018.12.21.09.58.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 09:58:04 -0800 (PST) Date: Fri, 21 Dec 2018 17:58:03 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20181221175802.skyh2iwsippreaez@bivouac.eciton.net> References: <20181220191653.8671-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181220191653.8671-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 17:58:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 17:58:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 20, 2018 at 08:16:53PM +0100, Ard Biesheuvel wrote: > Clang 7 complains about the vmsr instruction in ArmV7Support.S, > which is only available on cores that implement some flavour of > VFP. So set the .fpu to NEON like we do in some other places. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmLib/Arm/ArmV7Support.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > index 281499b46cbc..1808962ee3e2 100644 > --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > @@ -268,6 +268,7 @@ ASM_FUNC(ArmEnableVFP) > #ifndef __clang__ > mcr p10,#0x7,r0,c8,c0,#0 > #else > + .fpu neon > vmsr fpexc, r0 > #endif No objection from me. But I would point out that the special clang filtering here could possibly be dropped. I mean, theoretically someone could have an even older binutils, but Linaro GCC 4.8-2013.05 will happily assemble the clang side of this conditional. / Leif