From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D27242194D387 for ; Fri, 21 Dec 2018 10:49:51 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id d15so6188576wmb.3 for ; Fri, 21 Dec 2018 10:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KVw1HHNSD8ryOAz97zlfBGfHsOR0vU4srWhfkFfABik=; b=KDyBk8jT0Rack4DJR7ljUioZCXmh0W8nd9bGITd/sGDHGFbNOZ5sQ/gDxjMgy0jjCd lOejsETWm5qyS5A6cyNIygdmfbfOcKg7jXFBFC57mvZVr//d4pxKokMt6jEENB4fQEuE GsfC9GvPEhPH1lgW2QQVUrfBNWPcPynLqowkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KVw1HHNSD8ryOAz97zlfBGfHsOR0vU4srWhfkFfABik=; b=SMYOEuZef84dJW+VlbrLVxE0GK/uU2/xeBKjqoP/sXGCQ9685ak2ikTZFPl3fo1S/s iEwndnSn7iQgWda6BY96LsnLtq2zYobKiqqBicCymCu77O9Q6yYXVX4z1bollNkGoiec +TjC2PjpIKR3jwTVv+K91t9cSGKozhXPwTwqikQFqQkjiuHmppkbku8he6iBibmwn7WW P06eYPADKpPnaZGu+bJ2Mc5Nzwb4vOSByRxgzXf1KSJ1JaOLil+MzHuaYmhAzSnZno0P /hk92vuXMxfNWf8PpnmV0uzGkbqIHsIBF96oNdwwvP3Yn8g7Pp2Jyup/xEsJIr9UYRfx CwjQ== X-Gm-Message-State: AJcUukdNQj/cAf6jkENoKo2Jd4PB4h7sZ82zJ+1NDBUgh3hn/Y6BtH36 Doo0Xzqg2Dwfq6bFmgZVk0jsEg== X-Google-Smtp-Source: AFSGD/UzVUDApMsbBBXXZ5t9thZmL5KDW99fX3gQyCyNuSLlslGKEUlMQZCDPqqasR6nhTgTeX/55A== X-Received: by 2002:a1c:85d2:: with SMTP id h201mr3662569wmd.151.1545418190197; Fri, 21 Dec 2018 10:49:50 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k23sm8150910wmj.32.2018.12.21.10.49.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 10:49:49 -0800 (PST) Date: Fri, 21 Dec 2018 18:49:47 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20181221184947.laeuns6qhppf5y7g@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-37-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-37-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 36/41] Silicon/NXP: Implement EFI_CPU_IO2_PROTOCOL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:49:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:50PM +0530, Meenakshi Aggarwal wrote: > From: Vabhav > > NXP SOC has mutiple PCIe RCs,Adding respective implementation of > EFI_CPU_IO2_PROTOCOL to provide Memory Space Read/Write functions > used by generic Host Bridge Driver including correct value for > the translation offset during MMIO accesses Could you let me know (not necessarily in the commit message) which implementation this is based on, so that I can have a look specifically at the diff? Really not a fan of this code, but most of the bits I dislike are copied from elsewhere. I will try to remember to go back and make the original(s) more C-like after the holidays. / Leif