From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 58A27210F4732 for ; Fri, 21 Dec 2018 10:51:59 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id a62so6204292wmh.4 for ; Fri, 21 Dec 2018 10:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q5RMx52ZXs97DtSNrl/wSRy1qdBQPQD8rnUoznU2cHw=; b=QvymO8juKvcnKzCRmI2V1pm8gCTFF5u35cXohTf8upldcllzjrGd5V9IwHCos/suYw 5AlnhHuitbGyuxyImlBvahOp/xSRjpzuTBRqGAh8mqyX3fjIZGFRNMyQ4ChmJPWh2tnH eDyHy061pLYmkC6fTHiAvyvfF/xzj2EW6fsxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q5RMx52ZXs97DtSNrl/wSRy1qdBQPQD8rnUoznU2cHw=; b=buy2YNtyYHH8JXbPJmV6HKbCVmH17np6i4GeVNdd58siRBcYaPVnVB5wlpOYzaZq8o Nj6J5Lzah8iPZFeQ99c/RtFuyh9ggrlQLmHPOMfvd48IvmwExBd6WmDS11mSay7iu74S 4OAbFZFwYUw3dJme6YzT1wyfviXPFycJUwGfNYMP1cEOeeAkX6QuSbnYd9J3mCJiCdH2 kRQXID9k1/k/pZ2wDB+cUpBRT4kW5iL6yyZAGxypoA0YYZdXJvCdN3HBMzErj4u1HR+r v3H5V403sDtDKNifp08c8zsKnWkrzuMGkVNaLsco2EKNS7smbskU4eIWIi+AVXgK+6jX JbsA== X-Gm-Message-State: AA+aEWa8BUsdmaXEI21uzH9ieKixTM1MZtr28M17yHazG6mGGIbuchl9 kOFQCG1HdeYo2ZrmnQvg6BDZ5Q== X-Google-Smtp-Source: ALg8bN7J40wyobhwNfqdH88VuF/giJVJrqF3nceGcGceKLM3y2NsIyxSIbFYgOlEi489jIA5O12bqQ== X-Received: by 2002:a7b:c853:: with SMTP id c19mr3701163wml.61.1545418317669; Fri, 21 Dec 2018 10:51:57 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c65sm13660057wma.24.2018.12.21.10.51.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 10:51:56 -0800 (PST) Date: Fri, 21 Dec 2018 18:51:55 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20181221185155.skepsb2at7koxubp@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-38-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-38-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 37/41] Compilation: Update the fdf, dsc and dec files. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:51:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:51PM +0530, Meenakshi Aggarwal wrote: > LS1043A PCIe compilation and update firmware device, > description and declaration files.Defining Embedded Package > PCD which should be at least 20 for 64K PCIe IO size required > for CPU hob during PEI phase to Add IO space post PEI phase. One change per patch please. This one needs to be at least two. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 16 ++++++++++++++++ > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 7 +++++++ > .../LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf | 2 ++ > .../LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 6 ++++++ > Platform/NXP/NxpQoriqLs.dsc.inc | 2 ++ > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 4 ++++ > Silicon/NXP/NxpQoriqLs.dec | 10 ++++++++++ > 7 files changed, 47 insertions(+) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index b69ffa2..b43c81a 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -42,6 +42,8 @@ > BoardLib|Platform/NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Silicon/NXP/Library/FpgaLib/FpgaLib.inf > NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > + PciSegmentLib|Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf > + PciHostBridgeLib|Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > [PcdsFixedAtBuild.common] > > @@ -74,6 +76,13 @@ > gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x060000000 > gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x60300000 > > + # > + # PCI PCDs. > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x10000 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x7FC > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -94,4 +103,11 @@ > Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > + Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > ## > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > index 6b27aed..d02b3cc 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > @@ -131,6 +131,13 @@ READ_LOCK_STATUS = TRUE > INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > # > + # PCI > + # > + INF Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > index 7feac56..f2c8b66 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > @@ -65,3 +65,5 @@ > gNxpQoriqLsTokenSpaceGuid.PcdDram3Size > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionBaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionSize > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > index 64c5612..1ef3292 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > +++ b/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > @@ -67,6 +67,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdCcsrSize); > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // ROM Space > + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdRomSize); > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // IFC region 1 > // > // A-009241 : Unaligned write transactions to IFC may result in corruption of data > diff --git a/Platform/NXP/NxpQoriqLs.dsc.inc b/Platform/NXP/NxpQoriqLs.dsc.inc > index 5529a04..063d0b8 100644 > --- a/Platform/NXP/NxpQoriqLs.dsc.inc > +++ b/Platform/NXP/NxpQoriqLs.dsc.inc > @@ -245,6 +245,8 @@ > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|20 > + > # > # Optional feature to help prevent EFI memory map fragments > # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob > diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > index a4eb117..f3220fa 100644 > --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc > +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > @@ -64,6 +64,9 @@ > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionBaseAddr|0x40000000 > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionSize|0x20000000 > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x1530000 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|3 > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x00000000 > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x00100000 > > # > # Big Endian IPs > @@ -71,5 +74,6 @@ > gNxpQoriqLsTokenSpaceGuid.PcdGurBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdWdogBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdIfcBigEndian|TRUE > + gNxpQoriqLsTokenSpaceGuid.PcdPciLutBigEndian|TRUE > > ## > diff --git a/Silicon/NXP/NxpQoriqLs.dec b/Silicon/NXP/NxpQoriqLs.dec > index da148b7..aae0a34 100644 > --- a/Silicon/NXP/NxpQoriqLs.dec > +++ b/Silicon/NXP/NxpQoriqLs.dec > @@ -78,6 +78,16 @@ > gNxpQoriqLsTokenSpaceGuid.PcdCcsrSize|0x0|UINT64|0x00000129 > gNxpQoriqLsTokenSpaceGuid.PcdDramMemSize|0x0|UINT64|0x0000012A > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x0|UINT64|0x0000012B > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x0|UINT64|0x0000012C > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x0|UINT64|0x0000012D > + > + # > + # PCI PCDs > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x0|UINT32|0x000001D0 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x0|UINT32|0x000001D1 > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE|BOOLEAN|0x000001D2 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|0|UINT32|0x000001D3 > > # > # IFC PCDs > -- > 1.9.1 >