From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 699E52119681D for ; Fri, 21 Dec 2018 11:05:08 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id r10so6310440wrs.10 for ; Fri, 21 Dec 2018 11:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R0GdMdOIsuAzhjP6WEeNS/a3g2wjE84bE40pxmQytSE=; b=jERJRgYKY5cGhdVfIO6+KG7Cmx6PAy9FM7lgFJKiygRuEIb+nblkeoI0KIbZhgCuon +SsncfGk037HbhwJl/nRXDoYmwgy+pFPP+l5nIDWby+M+GVCRL/pCKxSsqiDlYEqPnwZ vdeuWs1seP+veNHB9K6T1xORvdByWuuFfaZ8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R0GdMdOIsuAzhjP6WEeNS/a3g2wjE84bE40pxmQytSE=; b=hlbIH9FgNAPL6RHsxokPct1lWFDU6Xtw8QVTYVbdSIFfH6vnuY/+49uHewI5VMuIMI PW9Z1QWf8YgibVy8AjOz7uRTIr+qp2XQsVMTT5GQLInEEPqALuVWFvir9BghHWjSGAMO TBgcq7ZJzrqjlL8NkJ+KI7ncvbbYRIeB6wIxwWjz1+u/WrrFP9ZJ7aAiasyAhq9YN21H eIIv7hO61GjurtqoFZkwXTEfsxvbauVy94dgUqczjeLc7sf5L2JTgz6ESy6UsZJGtWds b0A59KcN7roS7wK3ka452fCj6c5jrMDrua0Ob8xx3TMkaaDYwVRibKONnRkhF6YkmpbB Oxiw== X-Gm-Message-State: AJcUukf66G7STVhUXyU1x9cHDlBvV+vg6RWTFlM6vOGzQjvycITsmX87 AcFmtszTiUlrwtIk6sLZbVtzSg== X-Google-Smtp-Source: ALg8bN5yvzmFTXiCsg26krTq2ZVafllRrN0sGbM6esBJ2GHk2rXGKo9ctZSBzYj+uDpmbrkwChLVcA== X-Received: by 2002:adf:9521:: with SMTP id 30mr3611830wrs.192.1545419106769; Fri, 21 Dec 2018 11:05:06 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o17sm20636376wmg.35.2018.12.21.11.05.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 11:05:05 -0800 (PST) Date: Fri, 21 Dec 2018 19:05:04 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20181221190504.gq3oosni446outwh@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-41-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-41-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 40/41] Platform/NXP:PCIe enablement for LS1046A RDB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:54PM +0530, Meenakshi Aggarwal wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. The diffstat below tells me that. The commit message is supposed to tell me what is changed, and why. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 15 +++++++++++++++ > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf | 7 +++++++ > .../LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf | 2 ++ > .../NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 6 ++++++ > Silicon/NXP/LS1046A/LS1046A.dsc.inc | 3 +++ > 5 files changed, 33 insertions(+) > > diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > index 7eb08a9..57f2043 100644 > --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc > @@ -41,6 +41,8 @@ > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > BoardLib|Platform/NXP/LS1046aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Silicon/NXP/Library/FpgaLib/FpgaLib.inf > + PciSegmentLib|Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf > + PciHostBridgeLib|Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > [PcdsFixedAtBuild.common] > > @@ -65,6 +67,7 @@ > gNxpQoriqLsTokenSpaceGuid.PcdGurBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdWdogBigEndian|TRUE > gNxpQoriqLsTokenSpaceGuid.PcdIfcBigEndian|TRUE > + gNxpQoriqLsTokenSpaceGuid.PcdPciLutBigEndian|TRUE > > # > # RTC Pcds > @@ -72,6 +75,12 @@ > gPcf2129RtcLibTokenSpaceGuid.PcdI2cSlaveAddress|0x51 > gPcf2129RtcLibTokenSpaceGuid.PcdI2cBusFrequency|100000 > > + # > + # PCI PCDs. > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x80000 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x407FC > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -85,6 +94,12 @@ > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > + Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > > Platform/NXP/LS1046aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > ## > diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > index 443b561..887f386 100644 > --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf > @@ -124,6 +124,13 @@ READ_LOCK_STATUS = TRUE > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > # > + # PCI > + # > + INF Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > index 49b57fc..5e09757 100644 > --- a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > @@ -42,6 +42,8 @@ > gArmTokenSpaceGuid.PcdArmPrimaryCore > gNxpQoriqLsTokenSpaceGuid.PcdCcsrBaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdCcsrSize > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1BaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1Size > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion2BaseAddr > diff --git a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > index 64c5612..1ef3292 100644 > --- a/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > +++ b/Platform/NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > @@ -67,6 +67,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdCcsrSize); > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // ROM Space > + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdRomSize); > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // IFC region 1 > // > // A-009241 : Unaligned write transactions to IFC may result in corruption of data > diff --git a/Silicon/NXP/LS1046A/LS1046A.dsc.inc b/Silicon/NXP/LS1046A/LS1046A.dsc.inc > index 9f87028..59a6150 100644 > --- a/Silicon/NXP/LS1046A/LS1046A.dsc.inc > +++ b/Silicon/NXP/LS1046A/LS1046A.dsc.inc > @@ -64,5 +64,8 @@ > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionBaseAddr|0x40000000 > gNxpQoriqLsTokenSpaceGuid.PcdQspiRegionSize|0x20000000 > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x1530000 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|3 > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x00000000 > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x00100000 > > ## > -- > 1.9.1 >