From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FDC22119681D for ; Fri, 21 Dec 2018 11:05:45 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id m1so6246459wml.2 for ; Fri, 21 Dec 2018 11:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FcDVJd2GXA1bcYQlsuE3sgInhS9GqH8+tFaDht+wBgo=; b=W9FucNAdmt5vm802///jbYXwvMAs0ItWK9+7LrDV+xrFJiuS0jwINOZwCLroFFpHX5 s7OzpqQnqw7MFcUj6zAREyT7IkAHiEBbPuoFdVvhrEMul13uCNpHWLgh5qKkeWqptu3n biAYvZvf9h8M2xWr4jxsU8MkeVx7jxxVHzEQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FcDVJd2GXA1bcYQlsuE3sgInhS9GqH8+tFaDht+wBgo=; b=oYmJfHKgVwjwB16+AFfaPMpDWuekYXqsfBQyotdHuiaiZDyVTcrIB5aXcfoU3w87jK K572+xIKhDQLXvQAUy0Qn7l8QYjPzyVJJfiGPZVLV8Gx5toXoUwB5lgALvZpLlvUNVxy XRR3mowrXbO3boz+7Ug8FbkGyFRtYU3WMBti5oGGPlMSX2VUIMGJvOBRaYSCyKzj9RiV Old2T61GXdgR5L9/UrXsJPRcBPgpIypnZ7OytdLTzfAHR2xwJrQrk4osuCep+HSoK2oj uz0S4gqQQmrLGJ+AGR5FKCXWpohwR0r6Fz58No2JKcuk62Ng/Vklx4KNaNEtBO8iZfnL lzQA== X-Gm-Message-State: AJcUukcVcK79iW1f6a57YqC1758cl2Hf0ObF+P7UipTz2rD4kwXfsTwo 7lQRUv3pmpd+VyCzbHnmSFdrFg2wjEI= X-Google-Smtp-Source: ALg8bN7cSSiy8DS0pzLy21CCARC90B1SYHvSdKh+X43c/+kMl+0vei77luMzh5PoJDU0DXXfRa8PEA== X-Received: by 2002:a1c:5a42:: with SMTP id o63mr3859662wmb.88.1545419143974; Fri, 21 Dec 2018 11:05:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t4sm15621843wrm.6.2018.12.21.11.05.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 11:05:43 -0800 (PST) Date: Fri, 21 Dec 2018 19:05:41 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, udit.kumar@nxp.com, v.sethi@nxp.com, Vabhav Message-ID: <20181221190541.4pxuzbsonav75bjs@bivouac.eciton.net> References: <1518771035-6733-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1543417315-5763-42-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543417315-5763-42-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 41/41] Platform/NXP:PCIe enablement for LS2088A RDB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:05:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 08:31:55PM +0530, Meenakshi Aggarwal wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. Please add a commit message. This isn't one. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 17 +++++++++++++++++ > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf | 7 +++++++ > .../Library/PlatformLib/ArmPlatformLib.inf | 2 ++ > .../LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 6 ++++++ > Silicon/NXP/LS2088A/LS2088A.dsc.inc | 3 +++ > 5 files changed, 35 insertions(+) > > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > index e074991..aefc214 100755 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc > @@ -43,6 +43,8 @@ > BoardLib|Platform/NXP/LS2088aRdbPkg/Library/BoardLib/BoardLib.inf > FpgaLib|Platform/NXP/LS2088aRdbPkg/Library/FpgaLib/FpgaLib.inf > NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > + PciSegmentLib|Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf > + PciHostBridgeLib|Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > [PcdsFixedAtBuild.common] > > @@ -92,6 +94,13 @@ > gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x580000000 > gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x580300000 > > + # > + # PCI PCDs. > + # > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x80000 > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x407FC > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -111,3 +120,11 @@ > Platform/NXP/LS2088aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > + Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + ## > diff --git a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > index 62f084d..d32c5a0 100644 > --- a/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > +++ b/Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf > @@ -129,6 +129,13 @@ READ_LOCK_STATUS = TRUE > INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > # > + # PCI > + # > + INF Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + > + # > # Network modules > # > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > diff --git a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > index f5e5abd..0b836a8 100644 > --- a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > @@ -44,6 +44,8 @@ > gArmTokenSpaceGuid.PcdArmPrimaryCore > gNxpQoriqLsTokenSpaceGuid.PcdCcsrBaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdCcsrSize > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1BaseAddr > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion1Size > gNxpQoriqLsTokenSpaceGuid.PcdIfcRegion2BaseAddr > diff --git a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > index ccb49f6..8b2145b 100644 > --- a/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > +++ b/Platform/NXP/LS2088aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > @@ -80,6 +80,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdCcsrSize); > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // ROM Space > + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdRomBaseAddr); > + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdRomSize); > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // IFC region 1 > // > // A-009241 : Unaligned write transactions to IFC may result in corruption of data > diff --git a/Silicon/NXP/LS2088A/LS2088A.dsc.inc b/Silicon/NXP/LS2088A/LS2088A.dsc.inc > index 0d8fd82..831edea 100644 > --- a/Silicon/NXP/LS2088A/LS2088A.dsc.inc > +++ b/Silicon/NXP/LS2088A/LS2088A.dsc.inc > @@ -69,5 +69,8 @@ > gNxpQoriqLsTokenSpaceGuid.PcdNumI2cController|4 > gNxpQoriqLsTokenSpaceGuid.PcdIfcBaseAddr|0x02240000 > gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2 > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|4 > + gNxpQoriqLsTokenSpaceGuid.PcdRomBaseAddr|0x00000000 > + gNxpQoriqLsTokenSpaceGuid.PcdRomSize|0x00100000 > > ## > -- > 1.9.1 >