public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com,
	edk2-devel@lists.01.org
Subject: Re: EmbeddedPkg : Corrected flow for setting Buswidth for eMMC
Date: Fri, 21 Dec 2018 19:23:11 +0000	[thread overview]
Message-ID: <20181221192311.nfuvwgzi2lbsj5l2@bivouac.eciton.net> (raw)
In-Reply-To: <1543919330-32761-1-git-send-email-meenakshi.aggarwal@nxp.com>

What is the incorrectness that is being resolved, and how is it being
resolved?

(Add a commit message, please.)

On Tue, Dec 04, 2018 at 03:58:50PM +0530, Meenakshi Aggarwal wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> index f661a0c..9118eb2 100755
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> @@ -309,11 +309,14 @@ InitializeEmmcDevice (
>        }
>        Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode);
>        if (EFI_ERROR (Status)) {
> -        DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status));
> +        continue;
> +      } else {
> +        DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode));
> +        break;
>        }
> -      return Status;
>      }
>    }
> +
>    return Status;
>  }
>  
> -- 
> 1.9.1
> 


      parent reply	other threads:[~2018-12-21 19:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 10:28 EmbeddedPkg : Corrected flow for setting Buswidth for eMMC Meenakshi Aggarwal
2018-12-04 14:47 ` Ard Biesheuvel
2018-12-21 19:23 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181221192311.nfuvwgzi2lbsj5l2@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox