From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::433; helo=mail-wr1-x433.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8602211958F9 for ; Fri, 21 Dec 2018 11:23:15 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id c14so6372434wrr.0 for ; Fri, 21 Dec 2018 11:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B0iG/8TAr/ZDNZZWJaYy9LF9AKhrK6BBJ76m1Z3PddI=; b=KlbP78tC3XYVQSUmtH/24Gxsje99HMqH7T2sXKlyT1WBWMxrAban81Nhc6XzNHQF0U kZWVIlJZtNHDKxjs19p1SHUbIXgvp9glhlPwy0pqnbNdF20IMaKxVMOq6+K99kfYdH10 IKqc04ALP9c8BN1u8nJ/eEpucud5MVDbOFusw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B0iG/8TAr/ZDNZZWJaYy9LF9AKhrK6BBJ76m1Z3PddI=; b=B2z0PcZTp6QsZjzulVQMSDSaS48i6LnPNneIW5Z7YCF66L1cqOXufQQDdrOP/WRZhm lKYtzW8sIHxxwPZ7Wuafc2PkSGStgaJxETHKs44LwEsL0Pa18Tt66yKM3jr+o3N8QPKG wsL8H0i5SoOnNWABmF4C+m/pg3U7GGxjlRGzBPCwNh+B4jKSv2DpHu7gyy7oo5i9jjoB 4JwsmHd8eM89hQhSQSwJveOf3hix9e8ktspFO/3VYBVbHHlFdxR3suzh53o1m0FPs/8Q +13bMr7ekxSHrMpl6IfgGSW9GTNP0WRJvj0knK6vqTVG4yiEY6CvQGJWRJMKS22e60Fc 0IYA== X-Gm-Message-State: AJcUukfVEK1r+vXXdTLQ5zIltljqR7xKvAeCJEpOkR75o0YIoAUCAWhZ tgEdOw/dMHPhGBcltT14fcYTuQ== X-Google-Smtp-Source: ALg8bN7Klc/ohZc77dBqmDlBocYhzF+KdeSYy9kZZLgMu0wNLxKEKZS17QzLUdsm6swMDU3lsZpR0g== X-Received: by 2002:adf:ba8e:: with SMTP id p14mr3747110wrg.230.1545420193736; Fri, 21 Dec 2018 11:23:13 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c77sm14812681wmh.12.2018.12.21.11.23.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 11:23:12 -0800 (PST) Date: Fri, 21 Dec 2018 19:23:11 +0000 From: Leif Lindholm To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org Message-ID: <20181221192311.nfuvwgzi2lbsj5l2@bivouac.eciton.net> References: <1543919330-32761-1-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1543919330-32761-1-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: EmbeddedPkg : Corrected flow for setting Buswidth for eMMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 X-List-Received-Date: Fri, 21 Dec 2018 19:23:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline What is the incorrectness that is being resolved, and how is it being resolved? (Add a commit message, please.) On Tue, Dec 04, 2018 at 03:58:50PM +0530, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index f661a0c..9118eb2 100755 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -309,11 +309,14 @@ InitializeEmmcDevice ( > } > Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status)); > + continue; > + } else { > + DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode)); > + break; > } > - return Status; > } > } > + > return Status; > } > > -- > 1.9.1 >