From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7AFEF2194D387 for ; Fri, 21 Dec 2018 11:50:53 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r10so6418218wrs.10 for ; Fri, 21 Dec 2018 11:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1hfSVzXjIm9Ht8ZuVyf/2QSrauKxZ4sFOhFcj7CwHt0=; b=iB9wJdOeM1oKDhHCmnU+1aGN28oJriqXyS3B51XT6AFmvnoo52Qv+g7VpBeV4mG/iC UTZ0BL6nEaT7MuDWY//SYIoilfPQ23h7mISXCgcvL6gpTz4V4eKpM9fWlu7TmEF51FSa lsg3V6cgpZCMVLikRP9K3uNhTjReiGwK3i+OI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1hfSVzXjIm9Ht8ZuVyf/2QSrauKxZ4sFOhFcj7CwHt0=; b=GBS/X9YQ6X9FGN29IVt/HVHmeWZ6yer43hMy67Fvw9chd6b7CUPtSqnZGWH6MiLrYZ sOdDoAc+7qWQoVf8q5U9DgtqjEmAugEGHCHOkPf8nl4nxK1R1h9ifB8joWGZRztc1hSk lQf+MVRxfSTqL78XiA6aQ/W65W0krjMM5VDwhyQSeI64H6oQYiEZdNFI9Dpflge1o0UM 2evyC/pbSspPL59EumtuABq6u7g+OEqaJuFGiPvcQyN/fw1EARM8uv7cCQSZE/orW6Wn VFwGmt9PpdR/27tac5CpeIT26bSB+HjT17wdCUodKHG5s6jON8qq5QkWxavrzLpf/nJ2 TuTA== X-Gm-Message-State: AJcUukcbq/H70Nh+AjJP5JdypTFTHj7unwF131g0vrY6aa/gArWk1CHm nW4Pw/wnPdzq3P5GSY7BTnddFg== X-Google-Smtp-Source: ALg8bN4oZ9ovL4b5KgKe3vq/u/YQGE9jnmwPrHInwGweRdaIj5ccTwr/uApohJs3j3tp/BXTbX2oJg== X-Received: by 2002:adf:82a4:: with SMTP id 33mr3692224wrc.252.1545421851809; Fri, 21 Dec 2018 11:50:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b18sm15706313wrw.83.2018.12.21.11.50.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 11:50:50 -0800 (PST) Date: Fri, 21 Dec 2018 19:50:49 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Andrew Fish Message-ID: <20181221195049.mqaefrsx7jtp5vqs@bivouac.eciton.net> References: <20181220191653.8671-1-ard.biesheuvel@linaro.org> <20181221175802.skyh2iwsippreaez@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 19:50:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 21, 2018 at 07:00:04PM +0100, Ard Biesheuvel wrote: > On Fri, 21 Dec 2018 at 18:58, Leif Lindholm wrote: > > > > On Thu, Dec 20, 2018 at 08:16:53PM +0100, Ard Biesheuvel wrote: > > > Clang 7 complains about the vmsr instruction in ArmV7Support.S, > > > which is only available on cores that implement some flavour of > > > VFP. So set the .fpu to NEON like we do in some other places. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > --- > > > ArmPkg/Library/ArmLib/Arm/ArmV7Support.S | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > > index 281499b46cbc..1808962ee3e2 100644 > > > --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > > +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > > @@ -268,6 +268,7 @@ ASM_FUNC(ArmEnableVFP) > > > #ifndef __clang__ > > > mcr p10,#0x7,r0,c8,c0,#0 > > > #else > > > + .fpu neon > > > vmsr fpexc, r0 > > > #endif > > > > No objection from me. But I would point out that the special clang > > filtering here could possibly be dropped. > > > > I mean, theoretically someone could have an even older binutils, but > > Linaro GCC 4.8-2013.05 will happily assemble the clang side of this > > conditional. > > Yeah, but that would be a separate patch, no? Oh, sure. Just, it would be nice if that could precede this change. That said, the other two .fpu neon instances in edk2 are both hidden behind #if !defined(__APPLE__). Should we check with Andrew (post-wilderbeest) if this is something we need to keep (and if so add it here) or whether we can delete it across the board? / Leif