public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Shenglei Zhang <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: [PATCH v4 1/7] MdeModulePkg/EbcDebugger: Change function names
Date: Tue, 25 Dec 2018 16:17:11 +0800	[thread overview]
Message-ID: <20181225081717.2776-2-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20181225081717.2776-1-shenglei.zhang@intel.com>

Change UnicodeToUpper to InternalUnicodeToUpper.
Change AsciiToUpper to InternalAsciiToUpper.
These changes are committed for bisectability, or build failure will
occur when 2/7 is applied. Because the introduced function names in
2/7 are the same as ones in EdbSupporting.c.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../Universal/EbcDxe/EbcDebugger/EdbSupportString.c  | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
index 78a0559079..02e1876ffa 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
@@ -316,7 +316,7 @@ AsciiAtoi (
 **/
 STATIC
 CHAR16
-UnicodeToUpper (
+InternalUnicodeToUpper (
   IN      CHAR16                    Chr
   )
 {
@@ -332,7 +332,7 @@ UnicodeToUpper (
 **/
 STATIC
 CHAR8
-AsciiToUpper (
+InternalAsciiToUpper (
   IN      CHAR8                     Chr
   )
 {
@@ -390,12 +390,12 @@ StriCmp (
   )
 {
   while ((*String != L'\0') &&
-         (UnicodeToUpper (*String) == UnicodeToUpper (*String2))) {
+         (InternalUnicodeToUpper (*String) == InternalUnicodeToUpper (*String2))) {
     String++;
     String2++;
   }
 
-  return UnicodeToUpper (*String) - UnicodeToUpper (*String2);
+  return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper (*String2);
 }
 
 /**
@@ -418,12 +418,12 @@ StriCmpUnicodeAndAscii (
   )
 {
   while ((*String != L'\0') &&
-         (UnicodeToUpper (*String) == (CHAR16)AsciiToUpper (*String2))) {
+         (InternalUnicodeToUpper (*String) == (CHAR16)InternalAsciiToUpper (*String2))) {
     String++;
     String2++;
   }
 
-  return UnicodeToUpper (*String) - (CHAR16)AsciiToUpper (*String2);
+  return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper (*String2);
 }
 
 /**
-- 
2.18.0.windows.1



  reply	other threads:[~2018-12-25  8:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-25  8:17 [PATCH v4 0/7] Introduce two public functions and remove internal ones Shenglei Zhang
2018-12-25  8:17 ` Shenglei Zhang [this message]
2018-12-25  8:40   ` [PATCH v4 1/7] MdeModulePkg/EbcDebugger: Change function names Wu, Hao A
2018-12-25  8:17 ` [PATCH v4 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly Shenglei Zhang
2019-01-29  7:45   ` Ni, Ruiyu
2018-12-25  8:17 ` [PATCH v4 3/7] MdePkg/BaseLib: Remove definitions of two functions Shenglei Zhang
2018-12-25  8:17 ` [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper and CharToUpper Shenglei Zhang
2018-12-25  8:43   ` Wu, Hao A
2018-12-25  8:17 ` [PATCH v4 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiToUpper Shenglei Zhang
2018-12-25  8:46   ` Wu, Hao A
2018-12-25  8:17 ` [PATCH v4 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper Shenglei Zhang
2018-12-31 21:22   ` Carsey, Jaben
2018-12-25  8:17 ` [PATCH v4 7/7] ShellPkg/UefiShellLib: " Shenglei Zhang
2018-12-31 21:22   ` Carsey, Jaben
2018-12-26 20:11 ` [PATCH v4 0/7] Introduce two public functions and remove internal ones Laszlo Ersek
2019-01-29  3:10 ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181225081717.2776-2-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox