From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72A6D2119C8AD for ; Tue, 25 Dec 2018 00:17:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2018 00:17:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,395,1539673200"; d="scan'208";a="130497093" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga004.fm.intel.com with ESMTP; 25 Dec 2018 00:17:27 -0800 From: Shenglei Zhang To: edk2-devel@lists.01.org Cc: Jian J Wang , Hao Wu , Ruiyu Ni , Star Zeng Date: Tue, 25 Dec 2018 16:17:14 +0800 Message-Id: <20181225081717.2776-5-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20181225081717.2776-1-shenglei.zhang@intel.com> References: <20181225081717.2776-1-shenglei.zhang@intel.com> Subject: [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper and CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 08:17:28 -0000 InternalUnicodeToUpper and InternalAsciiToUpper are internal functions, so they are substituted by public functions AsciiToUpper and CharToUpper. And their implements are removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao Wu Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++----------------- 1 file changed, 4 insertions(+), 35 deletions(-) diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c index 02e1876ffa..c8d9fdcb2a 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c @@ -307,37 +307,6 @@ AsciiAtoi ( return RetVal; } -/** - - Convert the character to upper case. - - @param Chr the character to be converted. - -**/ -STATIC -CHAR16 -InternalUnicodeToUpper ( - IN CHAR16 Chr - ) -{ - return (Chr >= L'a' && Chr <= L'z') ? Chr - (L'a' - L'A') : Chr; -} - -/** - - Convert the character to upper case. - - @param Chr the character to be converted. - -**/ -STATIC -CHAR8 -InternalAsciiToUpper ( - IN CHAR8 Chr - ) -{ - return (Chr >= 'a' && Chr <= 'z') ? Chr - ('a' - 'A') : Chr; -} /** Compare the Unicode and Ascii string pointed by String to the string pointed by String2. @@ -390,12 +359,12 @@ StriCmp ( ) { while ((*String != L'\0') && - (InternalUnicodeToUpper (*String) == InternalUnicodeToUpper (*String2))) { + (CharToUpper (*String) == CharToUpper (*String2))) { String++; String2++; } - return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper (*String2); + return CharToUpper (*String) - CharToUpper (*String2); } /** @@ -418,12 +387,12 @@ StriCmpUnicodeAndAscii ( ) { while ((*String != L'\0') && - (InternalUnicodeToUpper (*String) == (CHAR16)InternalAsciiToUpper (*String2))) { + (CharToUpper (*String) == (CHAR16)AsciiToUpper (*String2))) { String++; String2++; } - return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper (*String2); + return CharToUpper (*String) - (CHAR16)AsciiToUpper (*String2); } /** -- 2.18.0.windows.1