From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=sughosh.ganu@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id D49752119F077 for ; Wed, 26 Dec 2018 18:58:41 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A80471596; Wed, 26 Dec 2018 18:58:40 -0800 (PST) Received: from a074948-lin.blr.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9870E3F5AF; Wed, 26 Dec 2018 18:58:38 -0800 (PST) Received: by a074948-lin.blr.arm.com (sSMTP sendmail emulation); Thu, 27 Dec 2018 08:28:35 +0530 Date: Thu, 27 Dec 2018 08:28:35 +0530 From: Sughosh Ganu To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm Message-ID: <20181227025835.GA30926@arm.com> References: <1545284878-21417-1-git-send-email-sughosh.ganu@arm.com> <1545284878-21417-2-git-send-email-sughosh.ganu@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH edk2-platforms v2 1/3] Platform/ARM/SgiPkg: Build infrastructure for StandaloneMm image X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 02:58:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu Dec 20, 2018 at 09:46:34AM +0100, Ard Biesheuvel wrote: > On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu wrote: > > > > Add the build infrastructure for compilation of StandaloneMm image > > files and FD file. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Sughosh Ganu > > --- > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 130 +++++++++++++++++++++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 100 +++++++++++++++++++++ > > 2 files changed, 230 insertions(+) > > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > new file mode 100644 > > index 000000000000..6b9d1e703869 > > --- /dev/null > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > @@ -0,0 +1,100 @@ > > +# > > +# Copyright (c) 2018, ARM Limited. All rights reserved. > > +# > > +# This program and the accompanying materials are licensed and made available > > +# under the terms and conditions of the BSD License which accompanies this > > +# distribution. The full text of the license may be found at > > +# http://opensource.org/licenses/bsd-license.php > > +# > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > +# > > + > > +################################################################################ > > +# > > +# FD Section > > +# The [FD] Section is made up of the definition statements and a > > +# description of what goes into the Flash Device Image. Each FD section > > +# defines one flash "device" image. A flash device image may be one of > > +# the following: Removable media bootable image (like a boot floppy > > +# image,) an Option ROM image (that would be "flashed" into an add-in > > +# card,) a System "Flash" image (that would be burned into a system's > > +# flash) or an Update ("Capsule") image that will be used to update and > > +# existing system flash. > > +# > > +################################################################################ > > + > > +[FD.BL32_AP_MM] > > +BaseAddress = 0xff200000|gArmTokenSpaceGuid.PcdFdBaseAddress # UEFI in DRAM + 128MB. > > +Size = 0x00e00000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the device (64MiB). > > +ErasePolarity = 1 > > Indent ^^ > > > + > > +# This one is tricky, it must be: BlockSize * NumBlocks = Size > > Please drop the silly line above > > > +BlockSize = 0x00001000 > > +NumBlocks = 0x0e00 > > + > > indent ^^^ > > > +0x00000000|0x00280000 > > +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > +FV = FVMAIN_COMPACT > > + > > +[FV.FVMAIN_COMPACT] > > +FvAlignment = 16 > > +ERASE_POLARITY = 1 > > +MEMORY_MAPPED = TRUE > > +STICKY_WRITE = TRUE > > +LOCK_CAP = TRUE > > +LOCK_STATUS = TRUE > > +WRITE_DISABLED_CAP = TRUE > > +WRITE_ENABLED_CAP = TRUE > > +WRITE_STATUS = TRUE > > +WRITE_LOCK_CAP = TRUE > > +WRITE_LOCK_STATUS = TRUE > > +READ_DISABLED_CAP = TRUE > > +READ_ENABLED_CAP = TRUE > > +READ_STATUS = TRUE > > +READ_LOCK_CAP = TRUE > > +READ_LOCK_STATUS = TRUE > > Indent ^^ Can you tell me what is the correct indentation here. I checked multiple platforms and they all seem to be using the same indentation. Or am i missing something here. -sughosh