* [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
@ 2019-01-07 6:55 Ard Biesheuvel
2019-01-07 10:08 ` Philippe Mathieu-Daudé
2019-01-14 11:41 ` Leif Lindholm
0 siblings, 2 replies; 8+ messages in thread
From: Ard Biesheuvel @ 2019-01-07 6:55 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, liming.gao, bob.c.feng, Ard Biesheuvel
GCC for 32-bit ARM chokes on .aslc files when running with LTO
enabled. Since LTO has no benefit whatsoever here, just disable
it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index f7eb87af14c2..e68cfd9a4997 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
*_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
*_GCC5_ARM_ARCHCC_FLAGS = -mthumb
-*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
+*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
*_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
*_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
*_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-07 6:55 [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations Ard Biesheuvel
@ 2019-01-07 10:08 ` Philippe Mathieu-Daudé
2019-01-14 11:41 ` Leif Lindholm
1 sibling, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-07 10:08 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: liming.gao
Hi Ard,
On 1/7/19 7:55 AM, Ard Biesheuvel wrote:
> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> enabled. Since LTO has no benefit whatsoever here, just disable
> it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index f7eb87af14c2..e68cfd9a4997 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
>
> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
Why not add it globally to GCC5_ASLCC_FLAGS?
> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-07 6:55 [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations Ard Biesheuvel
2019-01-07 10:08 ` Philippe Mathieu-Daudé
@ 2019-01-14 11:41 ` Leif Lindholm
2019-01-14 13:18 ` Gao, Liming
1 sibling, 1 reply; 8+ messages in thread
From: Leif Lindholm @ 2019-01-14 11:41 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, liming.gao, bob.c.feng
On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> enabled. Since LTO has no benefit whatsoever here, just disable
> it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Looks sensible.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index f7eb87af14c2..e68cfd9a4997 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
>
> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-14 11:41 ` Leif Lindholm
@ 2019-01-14 13:18 ` Gao, Liming
2019-01-14 13:36 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Gao, Liming @ 2019-01-14 13:18 UTC (permalink / raw)
To: Leif Lindholm, Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Feng, Bob C
Ard:
Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
Thanks
Liming
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, January 14, 2019 7:42 PM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
>
> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> > GCC for 32-bit ARM chokes on .aslc files when running with LTO
> > enabled. Since LTO has no benefit whatsoever here, just disable
> > it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Looks sensible.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> > ---
> > BaseTools/Conf/tools_def.template | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> > index f7eb87af14c2..e68cfd9a4997 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> > *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
> >
> > *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> > -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> > +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
> > *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> > *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> > *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-14 13:18 ` Gao, Liming
@ 2019-01-14 13:36 ` Philippe Mathieu-Daudé
2019-01-14 13:38 ` Gao, Liming
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-14 13:36 UTC (permalink / raw)
To: Gao, Liming, Leif Lindholm, Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On 1/14/19 2:18 PM, Gao, Liming wrote:
> Ard:
> Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
There might be a special case for Aarch64, but I'm not seeing it.
>
> Thanks
> Liming
>> -----Original Message-----
>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>> Sent: Monday, January 14, 2019 7:42 PM
>> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
>>
>> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
>>> GCC for 32-bit ARM chokes on .aslc files when running with LTO
>>> enabled. Since LTO has no benefit whatsoever here, just disable
>>> it.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Looks sensible.
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>>> ---
>>> BaseTools/Conf/tools_def.template | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
>>> index f7eb87af14c2..e68cfd9a4997 100755
>>> --- a/BaseTools/Conf/tools_def.template
>>> +++ b/BaseTools/Conf/tools_def.template
>>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
>>> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
>>>
>>> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
>>> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
>>> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
>>> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
>>> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
>>> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
>>> --
>>> 2.20.1
>>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-14 13:36 ` Philippe Mathieu-Daudé
@ 2019-01-14 13:38 ` Gao, Liming
2019-01-14 13:46 ` Ard Biesheuvel
0 siblings, 1 reply; 8+ messages in thread
From: Gao, Liming @ 2019-01-14 13:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Leif Lindholm, Ard Biesheuvel
Cc: edk2-devel@lists.01.org
I see IA32 and X64 arch both have this option. I have no idea on AArch64.
> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> Sent: Monday, January 14, 2019 9:36 PM
> To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
>
> On 1/14/19 2:18 PM, Gao, Liming wrote:
> > Ard:
> > Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
>
> There might be a special case for Aarch64, but I'm not seeing it.
>
> >
> > Thanks
> > Liming
> >> -----Original Message-----
> >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> >> Sent: Monday, January 14, 2019 7:42 PM
> >> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> >>
> >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> >>> enabled. Since LTO has no benefit whatsoever here, just disable
> >>> it.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>
> >> Looks sensible.
> >> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >>
> >>> ---
> >>> BaseTools/Conf/tools_def.template | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> >>> index f7eb87af14c2..e68cfd9a4997 100755
> >>> --- a/BaseTools/Conf/tools_def.template
> >>> +++ b/BaseTools/Conf/tools_def.template
> >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> >>> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
> >>>
> >>> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> >>> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> >>> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
> >>> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> >>> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> >>> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
> >>> --
> >>> 2.20.1
> >>>
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-14 13:38 ` Gao, Liming
@ 2019-01-14 13:46 ` Ard Biesheuvel
2019-01-14 13:57 ` Gao, Liming
0 siblings, 1 reply; 8+ messages in thread
From: Ard Biesheuvel @ 2019-01-14 13:46 UTC (permalink / raw)
To: Gao, Liming
Cc: Philippe Mathieu-Daudé, Leif Lindholm,
edk2-devel@lists.01.org
On Mon, 14 Jan 2019 at 14:38, Gao, Liming <liming.gao@intel.com> wrote:
>
> I see IA32 and X64 arch both have this option. I have no idea on AArch64.
>
I think we should just add it for all LTO toolchains in the GCC
family. These are fixed size data structures so LTO is entirely
pointless here.
> > -----Original Message-----
> > From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> > Sent: Monday, January 14, 2019 9:36 PM
> > To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> >
> > On 1/14/19 2:18 PM, Gao, Liming wrote:
> > > Ard:
> > > Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
> >
> > There might be a special case for Aarch64, but I'm not seeing it.
> >
> > >
> > > Thanks
> > > Liming
> > >> -----Original Message-----
> > >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > >> Sent: Monday, January 14, 2019 7:42 PM
> > >> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> > >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> > >>
> > >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> > >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> > >>> enabled. Since LTO has no benefit whatsoever here, just disable
> > >>> it.
> > >>>
> > >>> Contributed-under: TianoCore Contribution Agreement 1.1
> > >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >>
> > >> Looks sensible.
> > >> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > >>
> > >>> ---
> > >>> BaseTools/Conf/tools_def.template | 2 +-
> > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> > >>> index f7eb87af14c2..e68cfd9a4997 100755
> > >>> --- a/BaseTools/Conf/tools_def.template
> > >>> +++ b/BaseTools/Conf/tools_def.template
> > >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> > >>> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
> > >>>
> > >>> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> > >>> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> > >>> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
> > >>> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> > >>> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> > >>> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
> > >>> --
> > >>> 2.20.1
> > >>>
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
2019-01-14 13:46 ` Ard Biesheuvel
@ 2019-01-14 13:57 ` Gao, Liming
0 siblings, 0 replies; 8+ messages in thread
From: Gao, Liming @ 2019-01-14 13:57 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
That's great.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Monday, January 14, 2019 9:47 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
>
> On Mon, 14 Jan 2019 at 14:38, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > I see IA32 and X64 arch both have this option. I have no idea on AArch64.
> >
>
> I think we should just add it for all LTO toolchains in the GCC
> family. These are fixed size data structures so LTO is entirely
> pointless here.
>
>
> > > -----Original Message-----
> > > From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> > > Sent: Monday, January 14, 2019 9:36 PM
> > > To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: edk2-devel@lists.01.org
> > > Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> > >
> > > On 1/14/19 2:18 PM, Gao, Liming wrote:
> > > > Ard:
> > > > Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html?
> > >
> > > There might be a special case for Aarch64, but I'm not seeing it.
> > >
> > > >
> > > > Thanks
> > > > Liming
> > > >> -----Original Message-----
> > > >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > > >> Sent: Monday, January 14, 2019 7:42 PM
> > > >> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > >> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> > > >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations
> > > >>
> > > >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote:
> > > >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO
> > > >>> enabled. Since LTO has no benefit whatsoever here, just disable
> > > >>> it.
> > > >>>
> > > >>> Contributed-under: TianoCore Contribution Agreement 1.1
> > > >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > >>
> > > >> Looks sensible.
> > > >> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > > >>
> > > >>> ---
> > > >>> BaseTools/Conf/tools_def.template | 2 +-
> > > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>
> > > >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> > > >>> index f7eb87af14c2..e68cfd9a4997 100755
> > > >>> --- a/BaseTools/Conf/tools_def.template
> > > >>> +++ b/BaseTools/Conf/tools_def.template
> > > >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> > > >>> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy
> > > >>>
> > > >>> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb
> > > >>> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> > > >>> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto
> > > >>> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS)
> > > >>> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS)
> > > >>> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS)
> > > >>> --
> > > >>> 2.20.1
> > > >>>
> > > > _______________________________________________
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > > https://lists.01.org/mailman/listinfo/edk2-devel
> > > >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-14 13:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 6:55 [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations Ard Biesheuvel
2019-01-07 10:08 ` Philippe Mathieu-Daudé
2019-01-14 11:41 ` Leif Lindholm
2019-01-14 13:18 ` Gao, Liming
2019-01-14 13:36 ` Philippe Mathieu-Daudé
2019-01-14 13:38 ` Gao, Liming
2019-01-14 13:46 ` Ard Biesheuvel
2019-01-14 13:57 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox