From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, philmd@redhat.com, lersek@redhat.com
Subject: Re: [PATCH 0/4] ArmPkg: use console for minimal 'exception occurred' message
Date: Fri, 11 Jan 2019 17:49:41 +0000 [thread overview]
Message-ID: <20190111174941.zrqpfheppep3q6jj@bivouac.eciton.net> (raw)
In-Reply-To: <20181220173104.11481-1-ard.biesheuvel@linaro.org>
On Thu, Dec 20, 2018 at 06:31:00PM +0100, Ard Biesheuvel wrote:
> When running with a graphical console, no message whatsoever is printed
> when the systems hits an unexpected exception and hangs, because even
> the minimal 'exception occurred' message is only sent to the serial port.
>
> So let's fix that, by updating DefaultExceptionHandlerLib to take the
> availability of a console into account. (#4)
>
> This requires some preparatory decruftication so that we can safely refer
> to the system table and console (#1 .. #3).
>
> Ard Biesheuvel (4):
> ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling
> ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context
> ArmPkg/DefaultExceptionHandlerLib: drop BASE variant
> ArmPkg/DefaultExceptionHandlerLib: use console if available
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ArmPkg/ArmPkg.dsc | 1 -
> .../AArch64/DebugAgentException.S | 96 ------
> .../Arm/DebugAgentException.S | 277 ------------------
> .../Arm/DebugAgentException.asm | 273 -----------------
> .../DebugAgentSymbolsBaseLib.c | 7 -
> .../DebugAgentSymbolsBaseLib.inf | 9 -
> .../AArch64/DefaultExceptionHandler.c | 16 +-
> .../Arm/DefaultExceptionHandler.c | 7 +-
> .../DefaultExceptionHandlerBase.c | 35 ---
> .../DefaultExceptionHandlerLib.inf | 5 +-
> .../DefaultExceptionHandlerLibBase.inf | 45 ---
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> 12 files changed, 22 insertions(+), 750 deletions(-)
> delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S
> delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
> delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
> delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c
> delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
>
> --
> 2.19.2
>
prev parent reply other threads:[~2019-01-11 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 17:31 [PATCH 0/4] ArmPkg: use console for minimal 'exception occurred' message Ard Biesheuvel
2018-12-20 17:31 ` [PATCH 1/4] ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling Ard Biesheuvel
2018-12-20 17:31 ` [PATCH 2/4] ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context Ard Biesheuvel
2018-12-20 17:31 ` [PATCH 3/4] ArmPkg/DefaultExceptionHandlerLib: drop BASE variant Ard Biesheuvel
2018-12-26 21:27 ` Laszlo Ersek
2018-12-27 9:43 ` Ard Biesheuvel
2018-12-20 17:31 ` [PATCH 4/4] ArmPkg/DefaultExceptionHandlerLib: use console if available Ard Biesheuvel
2018-12-26 21:33 ` Laszlo Ersek
2018-12-27 9:43 ` Ard Biesheuvel
2019-01-11 17:49 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111174941.zrqpfheppep3q6jj@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox