From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D4C1211B6982 for ; Fri, 11 Jan 2019 09:49:44 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id f188so3176792wmf.5 for ; Fri, 11 Jan 2019 09:49:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7t+PcxmH0y02UiTAAZU8XY0To3SiRUGRE4SvdJEY4Mg=; b=it08+fWi0el3nWCmXbsdDU1UAglwbns3Jj2OlbNPGO1AxRhfD+vFm41+IRQe7vEkij y43ha4MRRZEZ0YxVwG9WGubV1c1TobGEanERkbFh4QwGyV8GEyyhMwB6e0VEtpUN37g4 xj82P1tYZ3IdrFtDmHdwZLCJU9IMkzveAE84g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7t+PcxmH0y02UiTAAZU8XY0To3SiRUGRE4SvdJEY4Mg=; b=H9edN2UN9Zb04y5UM8HlZ6ISIP2vTtuLPfKho1r5qtWjIeTB1t9TxjzhQ+2Hv6PFHl oaLBeA3NiH3yJbW0egsSesQryYQ3mzUhtcaECwNgrvvG1wrkD646++0FMlPN3PNyarp5 kPu0HdPymt9KIzNXybs4z9ZKMi8R6KBZt1DRCl7jCOEzmr1vikxKB2dkTYdm39St+uOD tdlkr1NAWbuD4fmECc9KenCfuCXYi3/PSPD2Z4ZN66yW1kNreyXVIyoqRroUPML87J5/ OYP9tnL9m48ldOX5AlusItriNLJXaQRFTDRcuEsQIkQPaLYTEuuMiNpgL5NXyqTDUxWR Xp0Q== X-Gm-Message-State: AJcUukeGwPl80Zhkh09RKz/tvDups9PGkNeu/JiHldtFWx+HHAvbQrqo BNgsoYsq+vj2fNtlU7pxjtPjhS+gqTo= X-Google-Smtp-Source: ALg8bN40Nzv+zK623mYoxC3C9DoLKgMRK26BVJwIEP0dpd4MIOaMUmdS6YsPOW6VJQHPctvy/JzNig== X-Received: by 2002:a1c:4683:: with SMTP id t125mr3343802wma.9.1547228983182; Fri, 11 Jan 2019 09:49:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a17sm63896482wrs.58.2019.01.11.09.49.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 09:49:42 -0800 (PST) Date: Fri, 11 Jan 2019 17:49:41 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, philmd@redhat.com, lersek@redhat.com Message-ID: <20190111174941.zrqpfheppep3q6jj@bivouac.eciton.net> References: <20181220173104.11481-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181220173104.11481-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/4] ArmPkg: use console for minimal 'exception occurred' message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 17:49:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 20, 2018 at 06:31:00PM +0100, Ard Biesheuvel wrote: > When running with a graphical console, no message whatsoever is printed > when the systems hits an unexpected exception and hangs, because even > the minimal 'exception occurred' message is only sent to the serial port. > > So let's fix that, by updating DefaultExceptionHandlerLib to take the > availability of a console into account. (#4) > > This requires some preparatory decruftication so that we can safely refer > to the system table and console (#1 .. #3). > > Ard Biesheuvel (4): > ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling > ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context > ArmPkg/DefaultExceptionHandlerLib: drop BASE variant > ArmPkg/DefaultExceptionHandlerLib: use console if available For the series: Reviewed-by: Leif Lindholm > ArmPkg/ArmPkg.dsc | 1 - > .../AArch64/DebugAgentException.S | 96 ------ > .../Arm/DebugAgentException.S | 277 ------------------ > .../Arm/DebugAgentException.asm | 273 ----------------- > .../DebugAgentSymbolsBaseLib.c | 7 - > .../DebugAgentSymbolsBaseLib.inf | 9 - > .../AArch64/DefaultExceptionHandler.c | 16 +- > .../Arm/DefaultExceptionHandler.c | 7 +- > .../DefaultExceptionHandlerBase.c | 35 --- > .../DefaultExceptionHandlerLib.inf | 5 +- > .../DefaultExceptionHandlerLibBase.inf | 45 --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > 12 files changed, 22 insertions(+), 750 deletions(-) > delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S > delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S > delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm > delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c > delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > > -- > 2.19.2 >