public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
Subject: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables.
Date: Mon, 14 Jan 2019 17:25:16 +0800	[thread overview]
Message-ID: <20190114092517.38448-2-songpeng.li@intel.com> (raw)
In-Reply-To: <20190114092517.38448-1-songpeng.li@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413

Global variables mIScsiDeviceListUpdated and
mNumberOfIScsiDevices have never been used, this patch
is to clean them.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
 NetworkPkg/IScsiDxe/IScsiConfig.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c
index 893eca61d5b1..83644f51d8d5 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
@@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include "IScsiImpl.h"
 
 CHAR16          mVendorStorageName[]     = L"ISCSI_CONFIG_IFR_NVDATA";
-BOOLEAN         mIScsiDeviceListUpdated  = FALSE;
-UINTN           mNumberOfIScsiDevices    = 0;
 ISCSI_FORM_CALLBACK_INFO  *mCallbackInfo = NULL;
 
 HII_VENDOR_DEVICE_PATH  mIScsiHiiVendorDevicePath = {
-- 
2.18.0.windows.1



  reply	other threads:[~2019-01-14  9:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
2019-01-14  9:25 ` Songpeng Li [this message]
2019-01-14 11:14   ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Fu, Siyuan
2019-01-14  9:25 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Songpeng Li
2019-01-14 11:14   ` Fu, Siyuan
2019-01-15  1:29 ` [PATCH v1 0/2] Remove unused global variables in Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114092517.38448-2-songpeng.li@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox